Defer notify scripts ready

Author: mgurgel

injected/src/features/duck-player-native.js

@@ -22,20 +22,23 @@ export class DuckPlayerNativeFeature extends ContentFeature {
     current;
 
     async init(args) {
-        console.log('DUCK PLAYER NATIVE LOADING', args, window.location.href);
+        console.log('DUCK PLAYER NATIVE LOADING', args, window.location.href); // TODO: REMOVE
 
         // TODO: May depend on page type
         /**
          * This feature never operates in a frame
          */
-        if (isBeingFramed()) return;
+        if (isBeingFramed()) {
+            console.log('FRAMED. ABORTING.'); // TODO: REMOVE
+            return;
+        }
 
         const selectors = this.getFeatureSetting('selectors');
-        console.log('DUCK PLAYER NATIVE SELECTORS', selectors);
+        console.log('DUCK PLAYER NATIVE SELECTORS', selectors); // TODO: REMOVE
 
         const locale = args?.locale || args?.language || 'en';
         const env = new Environment({
-            debug: this.isDebug || true, // TODO: remove
+            debug: this.isDebug || true, // TODO: REMOVE
             injectName: import.meta.injectName,
             platform: this.platform,
             locale,
@@ -68,11 +71,9 @@ export class DuckPlayerNativeFeature extends ContentFeature {
         console.log('INITIAL SETUP', initialSetup);
 
         if (initialSetup.pageType) {
-            console.log('GOT INITIAL PAGE TYPE', initialSetup.pageType);
+            console.log('GOT INITIAL PAGE TYPE', initialSetup.pageType); // TODO: REMOVE
             this.urlChangeHandler(initialSetup.pageType, selectors, env, messages);
         }
-
-        messages.notifyFeatureIsReady();
     }
 
     /**

injected/src/features/duckplayer-native/duckplayer-native.js

@@ -82,7 +82,9 @@ export class DuckPlayerNative {
         if (document.readyState === 'loading') {
             this.sideEffects.add('setting up load event listener', () => {
                 const loadHandler = () => {
+                    this.logger.log('Running deferred load handlers');
                     this.onLoad(this.sideEffects, this.logger);
+                    this.messages.notifyScriptIsReady();
                 };
                 document.addEventListener('DOMContentLoaded', loadHandler, { once: true });
 
@@ -93,9 +95,8 @@ export class DuckPlayerNative {
         } else {
             this.logger.log('Running load handlers immediately');
             this.onLoad(this.sideEffects, this.logger);
+            this.messages.notifyScriptIsReady();
         }
-
-        this.messages.notifyScriptIsReady();
     }
 }
 
@@ -118,6 +119,7 @@ export function setupDuckPlayerForYouTube(selectors, environment, messages) {
     const onInit = (sideEffects, logger) => {
         sideEffects.add('subscribe to media control', () => {
             return messages.subscribeToMediaControl(({ pause }) => {
+                console.log('MEDIA CONTROL', pause); // TODO: Remove
                 logger.log('Running media control handler. Pause:', pause);
 
                 const videoElement = selectors?.videoElement;