Fix issue when clearing empty databases

Author: greyivy

injected/integration-test/duck-ai-data-clearing.spec.js

@@ -96,6 +96,45 @@ test('duck-ai-data-clearing feature handles localStorage errors gracefully', asy
     expect(messages[0].payload.method).toBe('duckAiClearDataFailed');
 });
 
+test('duck-ai-data-clearing feature succeeds when data collections do not exist or are empty', async ({ page }, testInfo) => {
+    const collector = ResultsCollector.create(page, testInfo.project.use);
+    collector.withUserPreferences({
+        messageSecret: 'ABC',
+        javascriptInterface: 'javascriptInterface',
+        messageCallback: 'messageCallback',
+    });
+    await collector.load(HTML, CONFIG);
+    
+    const duckAiDataClearing = new DuckAiDataClearingSpec(page);
+    
+    // Ensure localStorage item doesn't exist
+    await page.evaluate(() => {
+        localStorage.removeItem('savedAIChats');
+    });
+    
+    // Ensure IndexedDB is clean (no existing database or object store)
+    await page.evaluate(() => {
+        return new Promise((resolve) => {
+            const deleteRequest = indexedDB.deleteDatabase('savedAIChatData');
+            deleteRequest.onsuccess = () => resolve(null);
+            deleteRequest.onerror = () => resolve(null); // Continue even if delete fails
+            deleteRequest.onblocked = () => resolve(null); // Continue even if blocked
+        });
+    });
+    
+    // Trigger data clearing on non-existent/empty data
+    await collector.simulateSubscriptionMessage('duckAiDataClearing', 'duckAiClearData', {});
+    
+    // Should still get completion message since there's nothing to fail
+    const messages = await collector.waitForMessage('duckAiClearDataCompleted', 1);
+    expect(messages).toHaveLength(1);
+    expect(messages[0].payload.method).toBe('duckAiClearDataCompleted');
+    
+    // Verify that subsequent verification shows no data exists
+    await duckAiDataClearing.verifyDataCleared();
+    await duckAiDataClearing.waitForVerification('Verification complete: All data cleared');
+});
+
 class DuckAiDataClearingSpec {
     /**
      * @param {import("@playwright/test").Page} page

injected/src/features/duck-ai-data-clearing.js

@@ -57,17 +57,31 @@ export class DuckAiDataClearing extends ContentFeature {
                     reject(new Error('No DB result'));
                     return;
                 }
+                
+                // Check if the object store exists
+                if (!db.objectStoreNames.contains('chat-images')) {
+                    this.log.info('chat-images object store does not exist, nothing to clear');
+                    db.close();
+                    resolve(null);
+                    return;
+                }
+                
                 try {
                     const transaction = db.transaction(['chat-images'], 'readwrite');
                     const objectStore = transaction.objectStore('chat-images');
                     const clearRequest = objectStore.clear();
-                    clearRequest.onsuccess = () => resolve(null);
+                    clearRequest.onsuccess = () => {
+                        db.close();
+                        resolve(null);
+                    };
                     clearRequest.onerror = (err) => {
                         this.log.error('Error clearing object store:', err);
+                        db.close();
                         reject(err);
                     };
                 } catch (err) {
                     this.log.error('Exception during IndexedDB clearing:', err);
+                    db.close();
                     reject(err);
                 }
             };