support noUnusedParameters (#1579)

Co-authored-by: Shane Osbourne <[email protected]>

Author: dbajpeyi

.github/scripts/diff-directories.js

@@ -26,7 +26,7 @@ function upperCaseFirstLetter(string) {
     return string.charAt(0).toUpperCase() + string.slice(1);
 }
 
-function displayDiffs(dir1Files, dir2Files, isOpen) {
+function displayDiffs(dir1Files, dir2Files) {
     const rollupGrouping = {};
     /**
      * Rolls up multiple files with the same diff into a single entry
@@ -79,13 +79,13 @@ function displayDiffs(dir1Files, dir2Files, isOpen) {
                 }
             }
             outString += '\n\n' + rollup.string;
-            return renderDetails(title, outString, isOpen);
+            return renderDetails(title, outString);
         })
         .join('\n');
     return outString;
 }
 
-function renderDetails(section, text, isOpen) {
+function renderDetails(section, text) {
     if (section === 'dist') {
         section = 'apple';
     }
@@ -120,5 +120,5 @@ sortFiles(readFilesRecursively(dir1 + sourcesOutput), 'dir1');
 sortFiles(readFilesRecursively(dir2 + sourcesOutput), 'dir2');
 
 // console.log(Object.keys(files))
-const fileOut = displayDiffs(sections.dir1, sections.dir2, true);
+const fileOut = displayDiffs(sections.dir1, sections.dir2);
 console.log(fileOut);

eslint.config.js

@@ -11,6 +11,7 @@ export default tseslint.config(
             '**/build/',
             '**/docs/',
             'injected/lib',
+            'injected/playwright-report/',
             'Sources/ContentScopeScripts/dist/',
             'injected/integration-test/extension/contentScope.js',
             'injected/integration-test/test-pages/duckplayer/scripts/dist',

injected/src/content-feature.js

@@ -137,7 +137,7 @@ export default class ContentFeature extends ConfigFeature {
         return processAttr(configSetting, defaultValue);
     }
 
-    init(args) {}
+    init(_args) {}
 
     callInit(args) {
         const mark = this.monitor.mark(this.name + 'CallInit');
@@ -153,7 +153,7 @@ export default class ContentFeature extends ConfigFeature {
         this.platform = args.platform;
     }
 
-    load(args) {}
+    load(_args) {}
 
     /**
      * This is a wrapper around `this.messaging.notify` that applies the
@@ -237,7 +237,7 @@ export default class ContentFeature extends ConfigFeature {
             if (typeof descriptorProp === 'function') {
                 const addDebugFlag = this.addDebugFlag.bind(this);
                 const wrapper = new Proxy(descriptorProp, {
-                    apply(target, thisArg, argumentsList) {
+                    apply(_, thisArg, argumentsList) {
                         addDebugFlag();
                         return Reflect.apply(descriptorProp, thisArg, argumentsList);
                     },

injected/src/features/broker-protection/actions/build-url-transforms.js

@@ -61,7 +61,7 @@ const optionalTransforms = new Map([
     ['defaultIfEmpty', (value, argument) => value || argument || ''],
     [
         'ageRange',
-        (value, argument, action) => {
+        (value, _, action) => {
             if (!action.ageRange) return value;
             const ageNumber = Number(value);
             // find matching age range
@@ -142,7 +142,7 @@ export function processTemplateStringWithUserData(input, action, userData) {
      * Note: this regex covers both pathname + query params.
      * This is why we're handling both encoded and un-encoded.
      */
-    return String(input).replace(/\$%7B(.+?)%7D|\$\{(.+?)}/g, (match, encodedValue, plainValue) => {
+    return String(input).replace(/\$%7B(.+?)%7D|\$\{(.+?)}/g, (_, encodedValue, plainValue) => {
         const comparison = encodedValue ?? plainValue;
         const [dataKey, ...transforms] = comparison.split(/\||%7C/);
         const data = userData[dataKey];

injected/src/features/broker-protection/actions/extract.js

@@ -91,7 +91,7 @@ export function extractProfiles(action, userData, root = document) {
 
     return {
         results: profilesElementList.map((element) => {
-            const elementFactory = (key, value) => {
+            const elementFactory = (_, value) => {
                 return value?.findElements
                     ? cleanArray(getElements(element, value.selector))
                     : cleanArray(getElement(element, value.selector) || getElementMatches(element, value.selector));

injected/src/features/broker-protection/types.js

@@ -76,12 +76,12 @@ export class ProfileResult {
  */
 export class Extractor {
     /**
-     * @param {string[]} noneEmptyStringArray
-     * @param {import("./actions/extract").ExtractorParams} extractorParams
+     * @param {string[]} _noneEmptyStringArray
+     * @param {import("./actions/extract").ExtractorParams} _extractorParams
      * @return {JsonValue}
      */
 
-    extract(noneEmptyStringArray, extractorParams) {
+    extract(_noneEmptyStringArray, _extractorParams) {
         throw new Error('must implement extract');
     }
 }
@@ -91,12 +91,12 @@ export class Extractor {
  */
 export class AsyncProfileTransform {
     /**
-     * @param {Record<string, any>} profile - The current profile value
-     * @param {Record<string, any>} profileParams - the original action params from `action.profile`
+     * @param {Record<string, any>} _profile - The current profile value
+     * @param {Record<string, any>} _profileParams - the original action params from `action.profile`
      * @return {Promise<Record<string, any>>}
      */
 
-    transform(profile, profileParams) {
+    transform(_profile, _profileParams) {
         throw new Error('must implement extract');
     }
 }

injected/src/features/message-bridge.js

@@ -221,7 +221,7 @@ export class MessageBridge extends ContentFeature {
         }
     }
 
-    load(args) {}
+    load(_args) {}
 }
 
 export default MessageBridge;

injected/src/features/web-compat.js

@@ -445,7 +445,7 @@ export class WebCompat extends ContentFeature {
             });
             // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
             this.defineProperty(window.safari.pushNotification, 'requestPermission', {
-                value: (name, domain, options, callback) => {
+                value: (_name, _domain, _options, callback) => {
                     if (typeof callback === 'function') {
                         callback(new SafariRemoteNotificationPermission());
                         return;

injected/src/utils.js

@@ -226,7 +226,7 @@ export function isFeatureBroken(args, feature) {
 }
 
 export function camelcase(dashCaseText) {
-    return dashCaseText.replace(/-(.)/g, (match, letter) => {
+    return dashCaseText.replace(/-(.)/g, (_, letter) => {
         return letter.toUpperCase();
     });
 }

injected/src/wrapper-utils.js

@@ -104,7 +104,7 @@ export function wrapFunction(functionValue, realTarget) {
             }
             return Reflect.get(target, prop, receiver);
         },
-        apply(target, thisArg, argumentsList) {
+        apply(_, thisArg, argumentsList) {
             // This is where we call our real function
             return Reflect.apply(functionValue, thisArg, argumentsList);
         },
@@ -228,7 +228,7 @@ export function shimInterface(interfaceName, ImplClass, options, definePropertyF
     // handle the case where the constructor is called without new
     if (fullOptions.allowConstructorCall) {
         // make the constructor function callable without new
-        proxyHandler.apply = function (target, thisArg, argumentsList) {
+        proxyHandler.apply = function (target, _thisArg, argumentsList) {
             return Reflect.construct(target, argumentsList, target);
         };
     }