injected: fixing flaky duckplayer tests (#1639)

* injected: fixing flaky duckplayer tests

* debugging

* faster

* naming

Author: shakyShane

.github/workflows/tests.yml

@@ -71,6 +71,12 @@ jobs:
                   name: playwright-report-pages
                   path: special-pages/playwright-report
                   retention-days: 5
+            - uses: actions/upload-artifact@v4
+              if: always()
+              with:
+                  name: playwright-report-injected
+                  path: injected/playwright-report
+                  retention-days: 5
             - name: Build docs
               run: npm run docs
 

injected/integration-test/duckplayer-mobile-drawer.spec.js

@@ -15,6 +15,7 @@ test.describe('Duck Player - Drawer UI variant', () => {
             await overlays.gotoPlayerPage();
 
             // watch here = overlays removed
+            await overlays.mobile.drawerIsPresented();
             await overlays.mobile.choosesWatchHere();
             await overlays.mobile.overlayIsRemoved();
             await overlays.pixels.sendsPixels([
@@ -34,6 +35,7 @@ test.describe('Duck Player - Drawer UI variant', () => {
             await overlays.gotoPlayerPage();
 
             // watch here = overlays removed
+            await overlays.mobile.drawerIsPresented();
             await overlays.mobile.selectsRemember();
             await overlays.mobile.choosesWatchHere();
             await overlays.mobile.overlayIsRemoved();
@@ -54,6 +56,7 @@ test.describe('Duck Player - Drawer UI variant', () => {
             await overlays.userSettingIs('always ask');
             await overlays.gotoPlayerPage();
 
+            await overlays.mobile.drawerIsPresented();
             await overlays.mobile.choosesDuckPlayer();
             await overlays.pixels.sendsPixels([
                 { pixelName: 'overlay', params: {} },
@@ -72,6 +75,7 @@ test.describe('Duck Player - Drawer UI variant', () => {
             await overlays.userSettingIs('always ask');
             await overlays.gotoPlayerPage();
 
+            await overlays.mobile.drawerIsPresented();
             await overlays.mobile.selectsRemember();
             await overlays.mobile.choosesDuckPlayer();
             await overlays.pixels.sendsPixels([

injected/integration-test/page-objects/duckplayer-overlays.js

@@ -542,6 +542,10 @@ class DuckplayerOverlaysMobile {
         this.overlays = overlays;
     }
 
+    async drawerIsPresented() {
+        const { page } = this.overlays;
+        await page.locator('ddg-video-drawer-mobile').waitFor({ state: 'visible', timeout: 2000 });
+    }
     async choosesWatchHere() {
         const { page } = this.overlays;
         await page.getByRole('button', { name: 'No Thanks' }).click();

injected/playwright.config.js

@@ -89,8 +89,8 @@ export default defineConfig({
     /* Retry on CI only */
     retries: process.env.CI ? 2 : 0,
     /* Opt out of parallel tests on CI. */
-    workers: process.env.CI ? 1 : undefined,
-    reporter: process.env.CI ? 'github' : [['html', { open: 'never' }]],
+    workers: process.env.CI ? 2 : undefined,
+    reporter: 'html',
     /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
     webServer: {
         reuseExistingServer: true,
@@ -105,5 +105,6 @@ export default defineConfig({
         baseURL: 'http://localhost:3220/',
         /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
         trace: 'on-first-retry',
+        video: { mode: 'on-first-retry' },
     },
 });