Device enumeration blocking WebCompat feature (#1724)

* Add enum devices debugging

* Disable device enumeration remotely

* Fix lint

* Add frame flexibility

* Move to webCompat

* Remove webCompat from extension build

Author: jonathanKingston

injected/src/features.js

@@ -46,7 +46,16 @@ export const platformSupport = {
     android: [...baseFeatures, 'webCompat', 'breakageReporting', 'duckPlayer', 'messageBridge'],
     'android-broker-protection': ['brokerProtection'],
     'android-autofill-password-import': ['autofillPasswordImport'],
-    windows: ['cookie', ...baseFeatures, 'windowsPermissionUsage', 'duckPlayer', 'brokerProtection', 'breakageReporting', 'messageBridge'],
+    windows: [
+        'cookie',
+        ...baseFeatures,
+        'windowsPermissionUsage',
+        'duckPlayer',
+        'brokerProtection',
+        'breakageReporting',
+        'messageBridge',
+        'webCompat',
+    ],
     firefox: ['cookie', ...baseFeatures, 'clickToLoad'],
     chrome: ['cookie', ...baseFeatures, 'clickToLoad'],
     'chrome-mv3': ['cookie', ...baseFeatures, 'clickToLoad'],

injected/src/features/web-compat.js

@@ -1,7 +1,7 @@
 import ContentFeature from '../content-feature.js';
 // eslint-disable-next-line no-redeclare
 import { URL } from '../captured-globals.js';
-
+import { DDGProxy } from '../utils';
 /**
  * Fixes incorrect sizing value for outerHeight and outerWidth
  */
@@ -126,6 +126,9 @@ export class WebCompat extends ContentFeature {
         if (this.getFeatureSettingEnabled('modifyCookies')) {
             this.modifyCookies();
         }
+        if (this.getFeatureSettingEnabled('disableDeviceEnumeration') || this.getFeatureSettingEnabled('disableDeviceEnumerationFrames')) {
+            this.preventDeviceEnumeration();
+        }
     }
 
     /** Shim Web Share API in Android WebView */
@@ -753,6 +756,27 @@ export class WebCompat extends ContentFeature {
             this.forceViewportTag(viewportTag, newContent.join(', '));
         }
     }
+
+    preventDeviceEnumeration() {
+        if (!window.MediaDevices) {
+            return;
+        }
+        let disableDeviceEnumeration = false;
+        const isFrame = window.self !== window.top;
+        if (isFrame) {
+            disableDeviceEnumeration = this.getFeatureSettingEnabled('disableDeviceEnumerationFrames');
+        } else {
+            disableDeviceEnumeration = this.getFeatureSettingEnabled('disableDeviceEnumeration');
+        }
+        if (disableDeviceEnumeration) {
+            const enumerateDevicesProxy = new DDGProxy(this, MediaDevices.prototype, 'enumerateDevices', {
+                apply() {
+                    return Promise.resolve([]);
+                },
+            });
+            enumerateDevicesProxy.overload();
+        }
+    }
 }
 
 /** @typedef {{title?: string, url?: string, text?: string}} ShareRequestData */