Switching to notifications

Author: mgurgel

injected/src/features/duckplayer-native/duckplayer-native.js

@@ -27,17 +27,17 @@ export async function initDuckPlayerNative(messages) {
     /**
      * Set up subscription listeners
      */
-    messages.onGetCurrentTimestamp(() => {
-        console.log('GET CURRENT TIMESTAMP');
-        getCurrentTimestamp();
-    });
+    // messages.onGetCurrentTimestamp(() => {
+    //     console.log('GET CURRENT TIMESTAMP');
+    //     getCurrentTimestamp();
+    // });
 
     messages.onMediaControl(() => {
         console.log('MEDIA CONTROL');
         mediaControl();
     });
 
-    messages.onMuteAudio((mute) => {
+    messages.onMuteAudio(({ mute }) => {
         console.log('MUTE AUDIO', mute);
         muteAudio(mute);
     });
@@ -52,6 +52,14 @@ export async function initDuckPlayerNative(messages) {
     const destroy = errorDetection.observe();
     if (destroy) sideEffects.push(destroy);
 
+    /* Start timestamp polling */
+    const timestampPolling = setInterval(() => {
+        messages.onGetCurrentTimestamp(getCurrentTimestamp());
+    });
+    sideEffects.push(() => {
+        clearInterval(timestampPolling);
+    });
+
     return async () => {
         return await Promise.all(sideEffects.map((destroy) => destroy()));
     };

injected/src/features/duckplayer-native/get-current-timestamp.js

@@ -1,7 +1,7 @@
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-nocheck - Typing will be fixed in the future
-
+/**
+ * @returns {number}
+ */
 export function getCurrentTimestamp() {
     const video = document.querySelector('video');
-    return video ? video.currentTime : 0;
+    return video?.currentTime || 0;
 }

injected/src/features/duckplayer-native/native-messages.js

@@ -1,5 +1,10 @@
 import * as constants from './constants.js';
 
+/**
+ * @typedef {object} muteSettings - Settings passing to the onMute callback
+ * @property {boolean} mute - Set to true to mute the video, false to unmute
+ */
+
 /**
  * @typedef {import("@duckduckgo/messaging").Messaging} Messaging
  *
@@ -38,11 +43,11 @@ export class DuckPlayerNativeMessages {
     }
 
     /**
-     * Subscribe to get current timestamp events
-     * @param {() => void} callback
+     * Notifies with current timestamp
+     * @param {number} timestamp
      */
-    onGetCurrentTimestamp(callback) {
-        return this.messaging.subscribe('onGetCurrentTimestamp', callback);
+    onGetCurrentTimestamp(timestamp) {
+        return this.messaging.notify('onGetCurrentTimestamp', { timestamp });
     }
 
     /**
@@ -55,7 +60,7 @@ export class DuckPlayerNativeMessages {
 
     /**
      * Subscribe to mute audio events
-     * @param {(mute: boolean) => void} callback
+     * @param {(muteSettings: muteSettings) => void} callback
      */
     onMuteAudio(callback) {
         return this.messaging.subscribe('onMuteAudio', callback);