feedback

Author: shakyShane

special-pages/pages/new-tab/app/omnibar/components/PersistentOmnibarValuesProvider.js

@@ -50,7 +50,7 @@ export function useQueryWithLocalPersistence(tabId) {
 
     invariant(
         useContext(OmnibarContext).state.status === 'ready',
-        'Cannot use `useQueryWithPersistence` without Omnibar Service being ready.',
+        'Cannot use `useQueryWithLocalPersistence` without Omnibar Service being ready.',
     );
 
     const [query, setQuery] = useState(() => terms?.byId(tabId) || '');
@@ -63,7 +63,7 @@ export function useQueryWithLocalPersistence(tabId) {
             }
             setQuery(term);
         },
-        [tabId],
+        [tabId, terms],
     );
 
     return /** @type {const} */ ([query, setter]);
@@ -106,7 +106,7 @@ export function useModeWithLocalPersistence(tabId, defaultMode) {
             }
             setState(v.data.mode);
         });
-    }, [service, tabId]);
+    }, [service, tabId, values]);
 
     return mode;
 }

special-pages/pages/new-tab/app/tabs/tabs.service.js

@@ -31,15 +31,6 @@ export class TabsService {
         return 'TabsService';
     }
 
-    /**
-     * @returns {Promise<{data: Tabs; config: null}>}
-     * @internal
-     */
-    async getInitial() {
-        const tabs = await this.tabsService.fetchInitial();
-        return { data: tabs, config: null };
-    }
-
     /**
      * @param {(evt: {data: Tabs, source: import('../service.js').InvocationSource}) => void} cb
      * @internal
@@ -60,7 +51,6 @@ export class TabsService {
      */
     snapshot() {
         if (!this.tabsService.data) throw new Error('unreachable');
-        console.log('did read');
         return this.tabsService.data;
     }
 }