From 6898a1c8157cbc22556483adb353bc50822cf0c8 Mon Sep 17 00:00:00 2001 From: Marcos Gurgel Date: Mon, 31 Mar 2025 12:40:46 +0100 Subject: [PATCH] Renamed message: thumbnail to dismiss --- .../integration-test/duckplayer-mobile-drawer.spec.js | 4 ++-- injected/src/features/duckplayer/overlay-messages.js | 4 ++-- injected/src/features/duckplayer/video-overlay.js | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/injected/integration-test/duckplayer-mobile-drawer.spec.js b/injected/integration-test/duckplayer-mobile-drawer.spec.js index dbdd7874fc..64fc82e23a 100644 --- a/injected/integration-test/duckplayer-mobile-drawer.spec.js +++ b/injected/integration-test/duckplayer-mobile-drawer.spec.js @@ -94,7 +94,7 @@ test.describe('Duck Player - Drawer UI variant', () => { await overlays.mobile.clicksOnVideoThumbnail(); await overlays.pixels.sendsPixels([ { pixelName: 'overlay', params: {} }, - { pixelName: 'play.do_not_use.thumbnail', params: {} }, + { pixelName: 'play.do_not_use.dismiss', params: {} }, ]); await overlays.userSettingWasNotUpdated(); }); @@ -112,7 +112,7 @@ test.describe('Duck Player - Drawer UI variant', () => { await overlays.mobile.clicksOnDrawerBackdrop(); await overlays.pixels.sendsPixels([ { pixelName: 'overlay', params: {} }, - { pixelName: 'play.do_not_use', params: {} }, + { pixelName: 'play.do_not_use.dismiss', params: {} }, ]); await overlays.userSettingWasNotUpdated(); }); diff --git a/injected/src/features/duckplayer/overlay-messages.js b/injected/src/features/duckplayer/overlay-messages.js index 6f9ab8f928..2c607ffb5d 100644 --- a/injected/src/features/duckplayer/overlay-messages.js +++ b/injected/src/features/duckplayer/overlay-messages.js @@ -157,7 +157,7 @@ export class Pixel { * | {name: "play.use", remember: "0" | "1"} * | {name: "play.use.thumbnail"} * | {name: "play.do_not_use", remember: "0" | "1"} - * | {name: "play.do_not_use.thumbnail"}} input + * | {name: "play.do_not_use.dismiss"}} input */ constructor(input) { this.input = input; @@ -177,7 +177,7 @@ export class Pixel { case 'play.do_not_use': { return { remember: this.input.remember }; } - case 'play.do_not_use.thumbnail': + case 'play.do_not_use.dismiss': return {}; default: throw new Error('unreachable'); diff --git a/injected/src/features/duckplayer/video-overlay.js b/injected/src/features/duckplayer/video-overlay.js index e308ce2486..28936a7851 100644 --- a/injected/src/features/duckplayer/video-overlay.js +++ b/injected/src/features/duckplayer/video-overlay.js @@ -292,10 +292,10 @@ export class VideoOverlay { return this.mobileOptOut(e.detail.remember).catch(console.error); }); drawer.addEventListener(DDGVideoDrawerMobile.DISMISS, () => { - return this.mobileOptOut(false).catch(console.error); // Dismissal should not persist user's choice. Ignore remember-me value. + return this.dismissOverlay(); }); drawer.addEventListener(DDGVideoDrawerMobile.THUMBNAIL_CLICK, () => { - return this.videoThumbnailClick(); + return this.dismissOverlay(); }); drawer.addEventListener(DDGVideoDrawerMobile.OPT_IN, (/** @type {CustomEvent<{remember: boolean}>} */ e) => { return this.mobileOptIn(e.detail.remember, params).catch(console.error); @@ -508,8 +508,8 @@ export class VideoOverlay { this.destroy(); } - videoThumbnailClick() { - const pixel = new Pixel({ name: 'play.do_not_use.thumbnail' }); + dismissOverlay() { + const pixel = new Pixel({ name: 'play.do_not_use.dismiss' }); this.messages.sendPixel(pixel); return this.destroy();