Skip to content

Duck Player entry point: updated messaging #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgurgel merged 1 commit into from
Apr 9, 2025
+8 −8
Merged

Duck Player entry point: updated messaging #1603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions injected/integration-test/duckplayer-mobile-drawer.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ test.describe('Duck Player - Drawer UI variant', () => {
await overlays.mobile.clicksOnVideoThumbnail();
await overlays.pixels.sendsPixels([
{ pixelName: 'overlay', params: {} },
{ pixelName: 'play.do_not_use.thumbnail', params: {} },
{ pixelName: 'play.do_not_use.dismiss', params: {} },
]);
await overlays.userSettingWasNotUpdated();
});
Expand All @@ -112,7 +112,7 @@ test.describe('Duck Player - Drawer UI variant', () => {
await overlays.mobile.clicksOnDrawerBackdrop();
await overlays.pixels.sendsPixels([
{ pixelName: 'overlay', params: {} },
{ pixelName: 'play.do_not_use', params: {} },
{ pixelName: 'play.do_not_use.dismiss', params: {} },
]);
await overlays.userSettingWasNotUpdated();
});
Expand Down
4 changes: 2 additions & 2 deletions injected/src/features/duckplayer/overlay-messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export class Pixel {
* | {name: "play.use", remember: "0" | "1"}
* | {name: "play.use.thumbnail"}
* | {name: "play.do_not_use", remember: "0" | "1"}
* | {name: "play.do_not_use.thumbnail"}} input
* | {name: "play.do_not_use.dismiss"}} input
*/
constructor(input) {
this.input = input;
Expand All @@ -177,7 +177,7 @@ export class Pixel {
case 'play.do_not_use': {
return { remember: this.input.remember };
}
case 'play.do_not_use.thumbnail':
case 'play.do_not_use.dismiss':
return {};
default:
throw new Error('unreachable');
Expand Down
8 changes: 4 additions & 4 deletions injected/src/features/duckplayer/video-overlay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,10 +292,10 @@ export class VideoOverlay {
return this.mobileOptOut(e.detail.remember).catch(console.error);
});
drawer.addEventListener(DDGVideoDrawerMobile.DISMISS, () => {
return this.mobileOptOut(false).catch(console.error); // Dismissal should not persist user's choice. Ignore remember-me value.
return this.dismissOverlay();
});
drawer.addEventListener(DDGVideoDrawerMobile.THUMBNAIL_CLICK, () => {
return this.videoThumbnailClick();
return this.dismissOverlay();
});
drawer.addEventListener(DDGVideoDrawerMobile.OPT_IN, (/** @type {CustomEvent<{remember: boolean}>} */ e) => {
return this.mobileOptIn(e.detail.remember, params).catch(console.error);
Expand Down Expand Up @@ -508,8 +508,8 @@ export class VideoOverlay {
this.destroy();
}

videoThumbnailClick() {
const pixel = new Pixel({ name: 'play.do_not_use.thumbnail' });
dismissOverlay() {
const pixel = new Pixel({ name: 'play.do_not_use.dismiss' });
this.messages.sendPixel(pixel);

return this.destroy();
Expand Down
Loading