Skip to content

Conversation

@madblex
Copy link
Contributor

@madblex madblex commented Apr 2, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1209854904049724

Description

Removes dependency on useEnhancedCaptchaSystem setting. See this asana message for context

Testing Steps

  • all unit and integration tests pass
  • test in Mac OS locally that nothing breaks

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@madblex madblex requested review from a team, brianhall and shakyShane as code owners April 2, 2025 10:24
@netlify
Copy link

netlify bot commented Apr 2, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 6d6fa5c
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67ed5eb89b8d640009e1bcd8
😎 Deploy Preview https://deploy-preview-1608--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

[Beta] Generated file diff

Time updated: Wed, 02 Apr 2025 15:59:28 GMT

Android
    - android/brokerProtection.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScopeIsolated.js

File has changed

@madblex madblex force-pushed the madblex/pir-deprecate-enhanced-captcha-system-setting branch from 0d71c56 to 1c51932 Compare April 2, 2025 14:03
@madblex madblex requested a review from jonathanKingston April 2, 2025 14:07
@madblex madblex force-pushed the madblex/pir-deprecate-enhanced-captcha-system-setting branch 2 times, most recently from b8fc323 to 653647c Compare April 2, 2025 15:51
@madblex madblex force-pushed the madblex/pir-deprecate-enhanced-captcha-system-setting branch from 653647c to 6d6fa5c Compare April 2, 2025 15:58
Copy link
Contributor

@brianhall brianhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM Alex, thanks.

Copy link
Contributor

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me based on the discussion in Asana. Haven't really checked the code fyi.

@madblex madblex merged commit 719673e into main Apr 3, 2025
15 checks passed
@madblex madblex deleted the madblex/pir-deprecate-enhanced-captcha-system-setting branch April 3, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants