Add TypeScript types to element-hiding feature #2016
+83
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add JSDoc type definitions matching element-hiding.ts schema - Cast getFeatureSetting return values to proper types with fallbacks - Update function parameter types to use new JSDoc types - Add type guards for union types (ElementHidingRule) - Preserve all original comments from codebase - Fix TypeScript compilation errors with proper null checks This integrates the refactored schema types from privacy-configuration into the content-scope-scripts element-hiding feature for better type safety and maintainability.
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[Beta] Generated file diffTime updated: Mon, 20 Oct 2025 12:19:09 GMT AndroidFile has changed AppleFile has changed Chrome-mv3File has changed FirefoxFile has changed IntegrationFile has changed WindowsFile has changed |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| selector = selector.concat(rule.selector, ','); | ||
| } else { | ||
| selector = selector.concat(rule.selector); | ||
| } |
There was a problem hiding this comment.
Bug: CSS Injection Fails with Missing Selectors
The injectStyleTag function can generate invalid CSS. When rules without a selector property are present, the logic for building the selector string skips them but still uses the original array index for comma placement. This can result in an empty selector string or trailing commas, leading to malformed CSS like :is() {}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1211479926220519?focus=true
Description
This integrates the refactored schema types from privacy-configuration into the content-scope-scripts element-hiding feature for better type safety and maintainability.
Testing Steps
Checklist
Please tick all that apply:
Note
Adds JSDoc typedefs and applies safer defaults and guards (for missing
selector/values) across element-hiding logic.ElementHidingValue,ElementHidingRuleWithSelector,ElementHidingRuleWithoutSelector,ElementHidingRule,ElementHidingDomain,StyleTagException,ElementHidingConfiguration.ElementHidingRule/ElementHidingValueand related types.selectorininjectStyleTagandhideAdNodes.rule.valuesbefore callingmodify-attr/modify-style.getFeatureSettingreturns with explicit defaults forrules,adLabelStrings,useStrictHideStyleTag,hideTimeouts,unhideTimeouts,mediaAndFormSelectors.collapseDomNode,expandNonEmptyDomNode,modifyAttribute,modifyStyle,extractTimeoutRules,injectStyleTag,hideAdNodes,applyRules).Written by Cursor Bugbot for commit 8247dc4. This will update automatically on new commits. Configure here.