Update history page loading background style #2075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: randerson <[email protected]>
|
Cursor Agent can help with this pull request. Just |
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Thu, 04 Dec 2025 00:22:07 GMT AppleFile has changed IntegrationFile has changed WindowsFile has changed |
Contributor
Author
|
@cursor Instead of removing the |
|
Done! I've updated the implementation as requested. The file now:
Note: I fixed a small typo in the suggested code ( <style>
html, body {
background: #fafafa;
}
@media screen and (prefers-color-scheme: dark) {
html, body {
background: #333;
}
}
</style>
<script>
// $LOADING_COLOR$ is replaced by native via string interpolation.
// This script must be in <head> to block rendering and prevent flash of wrong color.
const loadingColor = "$LOADING_COLOR$";
const hasLoadingColor = !!loadingColor && !loadingColor.startsWith("$");
if (hasLoadingColor) {
document.documentElement.style.background = loadingColor;
}
</script>Learn more about Cursor Agents |
Co-authored-by: randerson <[email protected]>
noisysocks
requested review from
a team,
mgurgel and
shakyShane
as code owners
shakyShane
approved these changes
Dec 4, 2025
noisysocks
deleted the
cursor/update-history-page-loading-background-style-claude-4.5-opus-high-thinking-4779
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue:
Description
Replaces static background color in
history/public/index.htmlwith a dynamic$LOADING_COLOR$token. This prevents a white flash during page initialization by allowing the native browser to set the background color.Testing Steps
<style>block inspecial-pages/pages/history/public/index.htmlmatches the new structure.Checklist
Please tick all that apply:
Note
Injects a head script that sets the page background to
$LOADING_COLOR$pre-render to avoid color flash.special-pages/pages/history/public/index.htmlto setdocument.documentElement.style.backgroundfrom$LOADING_COLOR$before render.Written by Cursor Bugbot for commit 6d107be. This will update automatically on new commits. Configure here.