Add and update RMF icons, update docs #2080
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkraucunas
requested review from
a team,
mgurgel and
shakyShane
as code owners
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Fri, 05 Dec 2025 05:24:19 GMT Apple
File has changed Removed Files
❌ File only exists in old changeset Integration
File has changed Windows
File has changed New Files
❌ File only exists in new changeset |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...al-pages/pages/new-tab/app/remote-messaging-framework/components/RemoteMessagingFramework.js
Show resolved
Hide resolved
vkraucunas
commented
Dec 5, 2025
|
|
||
| .content {} | ||
| .content { | ||
| width: 100%; |
Contributor
Author
There was a problem hiding this comment.
This was previously a flex-grow: 1;, that broke in some browsers. The width:100%;, will make it so short text doesn’t result in button migrating to center of card
vkraucunas
commented
Dec 5, 2025
| secondaryActionText: 'Remind me later, but only if I’m actually going to update soon', | ||
| }, | ||
| }, | ||
| big_single_action_announce: { |
Contributor
Author
There was a problem hiding this comment.
Added an example for each icon that isn’t included above
vkraucunas
force-pushed
the
vkraucunas/rmf-icons
branch
from
9459f16 to
ddf3fef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/414235014887631/task/1212148084413218?focus=true
Description
Adding more icon options to the RMF, documentation updated.
Adding and updating icons for the RMF. All icons renamed to include dimension (-96).
Adding
Renaming
Updating the actual svg to most up-to-date version from icons repo
Testing Steps
Checklist
Please tick all that apply:
Note
Adds new RMF icons (Radar, RadarCheck, Subscription, PIR), standardizes icon filenames to -96, and updates components, schema/types, examples, tests, and SVG assets accordingly.
./icons/${message.icon}-96.svginRemoteMessagingFrameworkand switch PIR banner icon toPIR-96.svg..contentto full width.Announce,AppUpdate,CriticalUpdate,PIR,Radar,RadarCheck,Subscription.View Results,Remind me later).rmf-message.jsonrmf-iconenum and generatedRMFIcontype withPIR,Radar,RadarCheck,Subscription; ensureAppUpdate,CriticalUpdate,DDGAnnounce,DuckAi,Announcepreserved.Radar-96.svg,RadarCheck-96.svg,Subscription-96.svg.Announce-96.svg,AppUpdate-96.svg,CriticalUpdate-96.svg.PrivacyPro.svgcontents to latest asset.Written by Cursor Bugbot for commit ddf3fef. This will update automatically on new commits. Configure here.