Skip to content

Conversation

@jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Dec 5, 2025

Added checks for opener and page reload status based on feature settings.

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/312629933896096/task/1212316965518834?focus=true

Description

Moves over: github.com/duckduckgo/duckduckgo-privacy-extension/blob/c78d96f4738b4cb2c99831a20e7186a161f8b446/shared/js/content-scripts/breakage-stats.js#L30 so we can have it on all platforms.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Note

Collects opener and pageReloaded values in breakage reports when corresponding feature settings are enabled.

  • Breakage reporting (injected/src/features/breakage-reporting.js):
    • Adds optional opener metric (!!window.opener) when opener setting is enabled.
    • Adds optional pageReloaded metric using performance.navigation.type === 1 or performance.getEntriesByType('navigation') includes reload when reloaded setting is enabled.

Written by Cursor Bugbot for commit 993eac7. This will update automatically on new commits. Configure here.

Added checks for opener and page reload status based on feature settings.
@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 993eac7
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/6932f8a2b8c8a00008b023a2
😎 Deploy Preview https://deploy-preview-2081--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

[Beta] Generated file diff

Time updated: Fri, 05 Dec 2025 15:23:31 GMT

Android
    - android/adsjsContentScope.js
  • android/contentScope.js

File has changed

Apple
    - apple/contentScopeIsolated.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

@jonathanKingston jonathanKingston marked this pull request as ready for review December 5, 2025 15:16
@jonathanKingston jonathanKingston requested a review from a team as a code owner December 5, 2025 15:16
@jonathanKingston jonathanKingston added this pull request to the merge queue Dec 5, 2025
Merged via the queue into main with commit cbdfc79 Dec 5, 2025
18 checks passed
@jonathanKingston jonathanKingston deleted the jonathanKingston-patch-3 branch December 5, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants