Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Commit 24c093e

Browse files
authored
Reduce number of buckets for open tabs daily pixel (#3663)
Task/Issue URL: https://app.asana.com/0/1206226850447395/1208866352354120/f Tech Design URL: CC: **Description**: Reduces the temporary high granularity of opened tabs buckets. **Steps to test this PR**: 1. Verify the validity of unit tests for daily open tabs pixel and whether they pass. **Definition of Done (Internal Only)**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
1 parent 4d78d09 commit 24c093e

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

DuckDuckGo/TabSwitcherOpenDailyPixel.swift

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,7 @@ struct TabSwitcherOpenDailyPixel {
4949
case 21...40: return "21-40"
5050
case 41...60: return "41-60"
5151
case 61...80: return "61-80"
52-
case 81...100: return "81-100"
53-
case 101...125: return "101-125"
54-
case 126...150: return "126-150"
55-
case 151...250: return "151-250"
56-
case 251...500: return "251-500"
57-
default: return "501+"
52+
default: return "81+"
5853
}
5954

6055
}

DuckDuckGoTests/TabSwitcherOpenDailyPixelTests.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,8 @@ final class TabSwitcherOpenDailyPixelTests: XCTestCase {
5151
21...40: "21-40",
5252
41...60: "41-60",
5353
61...80: "61-80",
54-
81...100: "81-100",
55-
101...125: "101-125",
56-
126...150: "126-150",
57-
151...250: "151-250",
58-
251...500: "251-500",
59-
501...504: "501+"]
54+
81...90: "81+",
55+
501...504: "81+"]
6056

6157
for bucket in bucketValues {
6258
for value in bucket.key {

0 commit comments

Comments
 (0)