Skip to content

Commit ba9766d

Browse files
authored
Fix cookie popup collector to pass rules dynamically (#180)
* pass cpm rules in init message * bump autoconsent * Fix tests
1 parent 7b533d3 commit ba9766d

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

collectors/CookiePopupsCollector.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ const ContentScriptCollector = require('./ContentScriptCollector');
44
const { createTimer } = require('../helpers/timer');
55
const { wait, TimeoutError } = require('../helpers/wait');
66
const createDeferred = require('../helpers/deferred');
7+
const rules = require('@duckduckgo/autoconsent/rules/rules.json');
8+
const stringifiedRules = JSON.stringify(rules);
79

810
// @ts-ignore
911
const baseContentScript = fs.readFileSync(
@@ -158,7 +160,7 @@ class CookiePopupsCollector extends ContentScriptCollector {
158160
isMainWorld: false,
159161
};
160162
await this.cdpSessions.get(executionContextUniqueId)?.send('Runtime.evaluate', {
161-
expression: `autoconsentReceiveMessage({ type: "initResp", config: ${JSON.stringify(autoconsentConfig)} })`,
163+
expression: `autoconsentReceiveMessage({ type: "initResp", config: ${JSON.stringify(autoconsentConfig)}, rules: ${stringifiedRules} })`,
162164
uniqueContextId: executionContextUniqueId,
163165
});
164166
break;

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
},
4444
"dependencies": {
4545
"@clickhouse/client": "^1.11.1",
46-
"@duckduckgo/autoconsent": "^14.11.0",
46+
"@duckduckgo/autoconsent": "^14.34.0",
4747
"@types/commander": "^2.12.0",
4848
"async": "^3.2.6",
4949
"chalk": "^4.1.2",

tests/collectors/CookiePopupsCollector.mocha.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
const CookiePopupsCollector = require('../../collectors/CookiePopupsCollector');
2+
const rules = require('@duckduckgo/autoconsent/rules/rules.json');
3+
const stringifiedRules = JSON.stringify(rules);
24
const assert = require('assert');
35
const sinon = require('sinon');
46

@@ -99,7 +101,7 @@ describe('CookiePopupsCollector', () => {
99101
enableHeuristicDetection: true,
100102
detectRetries: 20,
101103
isMainWorld: false,
102-
})} })`,
104+
})}, rules: ${stringifiedRules} })`,
103105
uniqueContextId: '1111',
104106
},
105107
]);

0 commit comments

Comments
 (0)