🐛 add missing parenthesis

Author: dudeofawesome

packages/create-configs/src/steps/scripts.spec.ts

@@ -1,5 +1,10 @@
 import { describe, it, expect } from '@jest/globals';
-import { _generate_build_script, _generate_lint_script } from './scripts.js';
+
+import {
+  _generate_build_script,
+  _generate_lint_script,
+  _generate_test_script,
+} from './scripts.js';
 
 describe('scripts', () => {
   describe(_generate_lint_script.name, () => {
@@ -20,6 +25,7 @@ describe('scripts', () => {
       });
 
       test_no_shell_globs(Object.values(output.scripts));
+      test_matched_braces(Object.values(output.scripts));
     });
 
     describe(`ts & js lint scripts`, () => {
@@ -39,6 +45,7 @@ describe('scripts', () => {
       });
 
       test_no_shell_globs(Object.values(output.scripts));
+      test_matched_braces(Object.values(output.scripts));
     });
 
     describe(`css lint scripts`, () => {
@@ -55,6 +62,7 @@ describe('scripts', () => {
       });
 
       test_no_shell_globs(Object.values(output.scripts));
+      test_matched_braces(Object.values(output.scripts));
     });
 
     describe(`css & scss lint scripts`, () => {
@@ -72,38 +80,85 @@ describe('scripts', () => {
       });
 
       test_no_shell_globs(Object.values(output.scripts));
+      test_matched_braces(Object.values(output.scripts));
     });
   });
 
   describe(_generate_build_script.name, () => {
-    describe(`ts lint scripts`, () => {
+    describe(`esbuild backend scripts`, () => {
       const output = _generate_build_script({
-        project_type: 'web-app',
+        project_type: 'backend',
         builder: 'esbuild',
         languages: ['ts'],
-        technologies: ['react'],
+        technologies: ['esm'],
         library: false,
-        input_dir: 'src/',
-        output_dir: 'dist/',
+        input_dir: 'src',
+        output_dir: 'dist',
       });
 
       it(`should create build scripts`, () => {
         expect(output.scripts.build).toMatch(/concurrently.+'npm:build:\*'/u);
         expect(output.scripts['build:js']).toMatch(/^esbuild /u);
+        expect(output.scripts['build:js']).toMatch(/\besm\b/u);
         expect(output.scripts['build:js']).not.toMatch(/\n/u);
       });
 
       test_no_shell_globs(Object.values(output.scripts));
+      test_matched_braces(Object.values(output.scripts));
+    });
+  });
+
+  describe(_generate_test_script.name, () => {
+    describe(`test scripts using node:test with esbuild`, () => {
+      const output = _generate_test_script({
+        builder: 'esbuild',
+        languages: ['ts'],
+        technologies: ['esm'],
+        output_dir: 'dist',
+        runtime: 'nodejs',
+      });
+
+      it(`should create build scripts`, () => {
+        expect(output.scripts.test).toMatch(/^node .*--test/u);
+        expect(output.scripts['test:debug']).toMatch(/--inspect-brk/u);
+        expect(output.scripts['test:debug']).not.toMatch(/NODE_OPTIONS=/u);
+      });
+
+      test_no_shell_globs(Object.values(output.scripts));
+      test_matched_braces(Object.values(output.scripts));
     });
   });
 });
 
-function test_no_shell_globs(scripts: string[]) {
+export function test_no_shell_globs(scripts: string[]) {
   // eslint-disable-next-line jest/require-top-level-describe
   it(`shouldn't allow the shell to expand globs`, () => {
+    expect.hasAssertions();
+    // expect.assertions(scripts.length);
+
     for (const script of scripts) {
       // https://regex101.com/r/e67boW/
       expect(script).toMatch(/(?:["'][\S]*?(\*)[\S]*?["']|^[^*]*$)/u);
     }
   });
 }
+
+export function test_matched_braces(scripts: string[]) {
+  // eslint-disable-next-line jest/require-top-level-describe
+  it(`should match opening & closing braces`, () => {
+    expect.hasAssertions();
+    // expect.assertions(scripts.length * 3);
+
+    for (const script of scripts) {
+      expect(script.match(/\(/gu)?.length).toEqual(
+        script.match(/\)/gu)?.length,
+      );
+      expect(script.match(/\[/gu)?.length).toEqual(
+        script.match(/\]/gu)?.length,
+      );
+      expect(script.match(/\{/gu)?.length).toEqual(
+        script.match(/\}/gu)?.length,
+      );
+    }
+  });
+}

packages/create-configs/src/steps/scripts.ts

@@ -137,8 +137,7 @@ export function _generate_build_script({
             --tsconfig=tsconfig.build.json
             $(${deps.d.depend('glob')}
               '${input_dir}/**/*.?(c|m)[jt]s'
-              --ignore '${test_file_glob}'
-            )
+              --ignore '${test_file_glob}')
             --outdir=${output_dir}
             --sourcemap=inline
             --platform=${project_type !== 'web-app' ? 'node' : 'browser'}
@@ -271,16 +270,18 @@ export function _generate_test_script({
             [
               `node $NODE_OPTS --import=${deps.d.depend('tsx')}`,
               `--test $(${deps.d.depend('glob')}`,
-              ...['**/node_modules/**', `**/${output_dir}/**`].map(
-                (ig) => `--ignore '${ig}'`,
-              ),
-              ...[
-                // Based on the default test file patterns:
-                //   https://nodejs.org/api/test.html#running-tests-from-the-command-line
-                `'**/*[.-_]test.?(c|m)[jt]s'`,
-                `'**/test?(-*).?(c|m)[jt]s'`,
-                `'**/test/**/*.?(c|m)[jt]s'`,
-              ],
+              [
+                ...['**/node_modules/**', `**/${output_dir}/**`].map(
+                  (ig) => `--ignore '${ig}'`,
+                ),
+                ...[
+                  // Based on the default test file patterns:
+                  //   https://nodejs.org/api/test.html#running-tests-from-the-command-line
+                  `'**/*[.-_]test.?(c|m)[jt]s'`,
+                  `'**/test?(-*).?(c|m)[jt]s'`,
+                  `'**/test/**/*.?(c|m)[jt]s'`,
+                ],
+              ].join(' ') + ')',
             ].join(' '),
           ].join('; '),
           'test:debug': `NODE_OPTS='--inspect-brk' npm run test`,