🚚 move eslint config package exports

dudeofawesome · dudeofawesome · commit b0150baff7de · 2023-09-26T17:26:18.000-07:00
this helps to ensure we're not accidentally using the wrong eslint config in testing
diff --git a/eslint-config-browser/base.yaml b/eslint-config-browser/base.yaml
diff --git a/eslint-config-browser/package.json b/eslint-config-browser/package.json
@@ -15,7 +15,7 @@
   ],
   "author": "Louis Orleans <louis@orleans.io>",
   "license": "MIT",
-  "main": ".eslintrc.yaml",
+  "main": "base.yaml",
   "scripts": {
     "test": "echo 'No tests'; exit 0"
   },
diff --git a/eslint-config-jest/base.yaml b/eslint-config-jest/base.yaml
diff --git a/eslint-config-jest/package.json b/eslint-config-jest/package.json
@@ -16,7 +16,7 @@
   ],
   "author": "Louis Orleans <louis@orleans.io>",
   "license": "MIT",
-  "main": ".eslintrc.yaml",
+  "main": "base.yaml",
   "scripts": {
     "test": "echo 'No tests'; exit 0"
   },
diff --git a/eslint-config-node/base.yaml b/eslint-config-node/base.yaml
@@ -2,6 +2,6 @@ extends:
   - 'plugin:@shopify/node'
 
 rules:
-  no-console: 'error'
   radix: 'off'
   node/exports-style: 'warn'
+  no-console: 'error' # this is a dupe from the base config, but shopify overrides it
diff --git a/eslint-config-node/package.json b/eslint-config-node/package.json
@@ -15,7 +15,7 @@
   ],
   "author": "Louis Orleans <louis@orleans.io>",
   "license": "MIT",
-  "main": ".eslintrc.yaml",
+  "main": "base.yaml",
   "scripts": {
     "test": "node --require ts-node/register --test test/index.ts"
   },
diff --git a/eslint-config-react/base.yaml b/eslint-config-react/base.yaml
diff --git a/eslint-config-react/package.json b/eslint-config-react/package.json
@@ -15,7 +15,7 @@
   ],
   "author": "Louis Orleans <louis@orleans.io>",
   "license": "MIT",
-  "main": ".eslintrc.yaml",
+  "main": "base.yaml",
   "scripts": {
     "test": "echo 'No tests'; exit 0"
   },
diff --git a/eslint-config-typescript/base.yaml b/eslint-config-typescript/base.yaml
@@ -1,7 +1,11 @@
 extends:
-  - 'plugin:@typescript-eslint/recommended'
+  - 'plugin:@typescript-eslint/strict'
+  # - 'plugin:@shopify/typescript'
   - 'plugin:import/typescript'
 
+parserOptions:
+  project: true
+
 rules:
   '@typescript-eslint/no-inferrable-types': 'off'
   '@typescript-eslint/no-unused-vars':
diff --git a/eslint-config-typescript/package.json b/eslint-config-typescript/package.json
@@ -15,7 +15,7 @@
   ],
   "author": "Louis Orleans <louis@orleans.io>",
   "license": "MIT",
-  "main": ".eslintrc.yaml",
+  "main": "base.yaml",
   "scripts": {
     "test": "node --require ts-node/register --test test/index.ts"
   },
diff --git a/eslint-config/base.yaml b/eslint-config/base.yaml
@@ -36,3 +36,5 @@ rules:
   no-use-before-define: 'off'
   eslint-comments/no-use: 'warn'
   '@shopify/binary-assignment-parens': 'off'
+  no-console: 'error'
+  # TODO: ban barrels
diff --git a/eslint-config/package.json b/eslint-config/package.json
@@ -15,7 +15,7 @@
   ],
   "author": "Louis Orleans <louis@orleans.io>",
   "license": "MIT",
-  "main": ".eslintrc.yaml",
+  "main": "base.yaml",
   "scripts": {
     "test": "node --require ts-node/register --test test/index.ts"
   },
