✅ add some more tests

Author: dudeofawesome

eslint-config-node/package.json

@@ -26,7 +26,6 @@
     "@dudeofawesome/eslint-config": "^1.0.0"
   },
   "devDependencies": {
-    "@swc/core": "^1.3.87",
     "@types/eslint": "^8.44.2",
     "@types/node": "^20.6.3",
     "ts-node": "^10.9.1"

eslint-config-node/test/index.ts

@@ -1,10 +1,8 @@
 import { describe, it } from 'node:test';
-import { strictEqual } from 'node:assert';
 import { ESLint } from 'eslint';
+import { testRuleFail, noLintMessage } from '../../utils/testing/eslint';
 
-const linter = new ESLint({
-  overrideConfigFile: `${__dirname}/.eslintrc.yaml`,
-});
+const linter = new ESLint({ cwd: __dirname });
 
 describe('eslint-config-node', () => {
   describe('passes', () => {
@@ -19,34 +17,3 @@ describe('eslint-config-node', () => {
       testRuleFail(linter, `if (Number == true) Number();\n`, 'eqeqeq'));
   });
 });
-
-async function testRuleFail(linter: ESLint, code: string, ruleId: string) {
-  const res = await linter.lintText(code);
-  singleLintMessage(res);
-  strictEqual(res[0].source, code);
-  strictEqual(res[0].messages[0].ruleId, ruleId);
-}
-
-function noLintMessage(lint_results: ESLint.LintResult[]) {
-  strictEqual(lint_results.length, 1, `Expected there to be no lint results.`);
-  strictEqual(
-    lint_results[0].errorCount,
-    0,
-    `Expected there to be no lint results.`,
-  );
-}
-
-function singleLintMessage(lint_results: ESLint.LintResult[]) {
-  strictEqual(
-    lint_results.length,
-    1,
-    `Expected there to be only one lint result.`,
-  );
-  strictEqual(
-    lint_results[0].messages.length,
-    1,
-    `Expected there to be one lint message, but there were ${
-      lint_results[0].messages.length
-    }: ${lint_results[0].messages.map((m) => m.message)}`,
-  );
-}

eslint-config/package.json

@@ -17,7 +17,7 @@
   "license": "MIT",
   "main": ".eslintrc.yaml",
   "scripts": {
-    "test": "echo 'No tests'; exit 0"
+    "test": "node --require ts-node/register --test test/index.ts"
   },
   "dependencies": {
     "@shopify/eslint-plugin": "^43.0.0",
@@ -27,5 +27,10 @@
   },
   "peerDependencies": {
     "prettier": "^3.0.3"
+  },
+  "devDependencies": {
+    "@types/eslint": "^8.44.2",
+    "@types/node": "^20.6.3",
+    "ts-node": "^10.9.1"
   }
 }

eslint-config/test/.eslintrc.yaml

@@ -0,0 +1,5 @@
+root: true
+extends:
+  - '@dudeofawesome'
+parserOptions:
+  ecmaVersion: 2022

eslint-config/test/index.ts

@@ -0,0 +1,16 @@
+import { describe, it } from 'node:test';
+import { ESLint } from 'eslint';
+import { testRuleFail } from '../../utils/testing/eslint';
+
+const linter = new ESLint({ cwd: __dirname });
+
+describe('eslint-config-node', () => {
+  describe('passes', () => {});
+  describe('fails', () => {
+    it(`should fail eqeqeq`, () =>
+      testRuleFail(linter, `if (Number == true) Number();\n`, 'eqeqeq'));
+
+    it(`should fail radix`, async () =>
+      testRuleFail(linter, `parseInt('10');\n`, 'radix'));
+  });
+});

package-lock.json

@@ -34,6 +34,8 @@
     "test": "npm run test --ws"
   },
   "devDependencies": {
-    "@dudeofawesome/code-style": "^1.0.0"
+    "@dudeofawesome/code-style": "^1.0.0",
+    "@types/eslint": "^8.44.2",
+    "@types/node": "^20.6.3"
   }
 }

package.json

@@ -0,0 +1,37 @@
+import { strictEqual } from 'node:assert';
+import { ESLint } from 'eslint';
+
+export async function testRuleFail(
+  linter: ESLint,
+  code: string,
+  ruleId: string,
+) {
+  const res = await linter.lintText(code);
+  singleLintMessage(res);
+  strictEqual(res[0].source, code);
+  strictEqual(res[0].messages[0].ruleId, ruleId);
+}
+
+export function noLintMessage(lint_results: ESLint.LintResult[]) {
+  strictEqual(lint_results.length, 1, `Expected there to be no lint results.`);
+  strictEqual(
+    lint_results[0].errorCount,
+    0,
+    `Expected there to be no lint results.`,
+  );
+}
+
+export function singleLintMessage(lint_results: ESLint.LintResult[]) {
+  strictEqual(
+    lint_results.length,
+    1,
+    `Expected there to be only one lint result.`,
+  );
+  strictEqual(
+    lint_results[0].messages.length,
+    1,
+    `Expected there to be one lint message, but there were ${
+      lint_results[0].messages.length
+    }:\n${lint_results[0].messages.map((m) => `  "${m.message}"`).join('\n')}`,
+  );
+}