Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Commit c2c9f78

Browse files
authored
Merge pull request #28 from duffelhq/FLAPI-2066-order-synced-at
Fix formatting of `synced_at`
2 parents e086a8f + 6f923d1 commit c2c9f78

File tree

6 files changed

+10
-3
lines changed

6 files changed

+10
-3
lines changed

duffel_api/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ def maybe_parse_date_entries(key, value):
1313
"pay_by",
1414
"confirmed_at",
1515
"cancelled_at",
16-
"synced_at",
1716
]:
1817
return datetime.strptime(value, "%Y-%m-%dT%H:%M:%S.%fZ")
1918

2019
if key in [
2120
"price_guarantee_expires_at",
2221
"payment_required_by",
22+
"synced_at",
2323
]:
2424
return datetime.strptime(value, "%Y-%m-%dT%H:%M:%SZ")
2525

tests/fixtures/create-order.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,7 @@
249249
]
250250
}
251251
],
252+
"synced_at": "2020-04-11T15:48:11Z",
252253
"tax_amount": "30.20",
253254
"tax_currency": "GBP",
254255
"total_amount": "90.80",

tests/fixtures/get-order-by-id.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@
251251
]
252252
}
253253
],
254-
"synced_at": "2020-04-11T15:48:11.642Z",
254+
"synced_at": "2020-04-11T15:48:11Z",
255255
"tax_amount": "30.20",
256256
"tax_currency": "GBP",
257257
"total_amount": "90.80",

tests/fixtures/get-orders.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,7 @@
250250
]
251251
}
252252
],
253+
"synced_at": "2020-04-11T15:48:11Z",
253254
"tax_amount": "30.20",
254255
"tax_currency": "GBP",
255256
"total_amount": "90.80",

tests/fixtures/update-order-by-id.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@
251251
]
252252
}
253253
],
254-
"synced_at": "2020-04-11T15:48:11.642Z",
254+
"synced_at": "2020-04-11T15:48:11Z",
255255
"tax_amount": "30.20",
256256
"tax_currency": "GBP",
257257
"total_amount": "90.80",

tests/test_orders.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import datetime
12
import pytest
23

34
from duffel_api.api import OrderCreate, OrderUpdate
@@ -10,6 +11,7 @@ def test_get_order_by_id(requests_mock):
1011
with fixture("get-order-by-id", url, requests_mock.get, 200) as client:
1112
order = client.orders.get("id")
1213
assert order.id == "ord_00009hthhsUZ8W4LxQgkjo"
14+
assert order.synced_at == datetime.datetime(2020, 4, 11, 15, 48, 11)
1315
assert len(order.slices) == 1
1416
assert len(order.passengers) == 1
1517
assert not order.live_mode
@@ -35,6 +37,7 @@ def test_get_orders(requests_mock):
3537
assert len(orders) == 1
3638
order = orders[0]
3739
assert order.id == "ord_00009hthhsUZ8W4LxQgkjo"
40+
assert order.synced_at == datetime.datetime(2020, 4, 11, 15, 48, 11)
3841

3942

4043
def test_create_order(requests_mock):
@@ -61,6 +64,7 @@ def test_create_order(requests_mock):
6164
.execute()
6265
)
6366
assert order.id == "ord_00009hthhsUZ8W4LxQgkjo"
67+
assert order.synced_at == datetime.datetime(2020, 4, 11, 15, 48, 11)
6468
assert len(order.services) == 1
6569
service = order.services[0]
6670
assert service.id == "ser_00009UhD4ongolulWd9123"
@@ -124,6 +128,7 @@ def test_update_order(requests_mock):
124128
)
125129

126130
assert order.id == "ord_00009hthhsUZ8W4LxQgkjo"
131+
assert order.synced_at == datetime.datetime(2020, 4, 11, 15, 48, 11)
127132
assert order.metadata == {
128133
"customer_prefs": "window seat",
129134
"payment_intent_id": "pit_00009htYpSCXrwaB9DnUm2",

0 commit comments

Comments
 (0)