Merge pull request #331 from duffelhq/nlopes-fix-322

fix: add stops to slices segments

Author: Norberto Lopes

duffel_api/models/offer.py

@@ -221,6 +221,29 @@ def from_json(cls, json: dict):
         )
 
 
+@dataclass
+class OfferSliceSegmentStop:
+    """Additional segment-specific information about the stops"""
+
+    id: str
+    airport: Airport
+    departing_at: datetime
+    arriving_at: datetime
+    duration: str
+
+    @classmethod
+    def from_json(cls, json: dict):
+        """Construct a class instance from a JSON response."""
+        print(json)
+        return cls(
+            id=json["id"],
+            airport=Airport.from_json(json["airport"]),
+            departing_at=parse_datetime(json["departing_at"]),
+            arriving_at=parse_datetime(json["arriving_at"]),
+            duration=json["duration"],
+        )
+
+
 @dataclass
 class OfferSliceSegment:
     """The segments - that is, specific flights - that the airline is offering
@@ -242,6 +265,7 @@ class OfferSliceSegment:
     operating_carrier: Airline
     operating_carrier_flight_number: Optional[str]
     passengers: Sequence[OfferSliceSegmentPassenger]
+    stops: Sequence[OfferSliceSegmentStop]
 
     @classmethod
     def from_json(cls, json: dict):
@@ -270,6 +294,12 @@ def from_json(cls, json: dict):
                 ],
                 [],
             ),
+            stops=get_and_transform(
+                json,
+                "stops",
+                lambda value: [OfferSliceSegmentStop.from_json(stop) for stop in value],
+                [],
+            ),
         )
 
 

tests/fixtures/get-partial-offer-request-by-id.json

@@ -280,6 +280,7 @@
                       "type": "airport"
                     },
                     "departing_at": "2020-06-13T16:38:02",
+                    "arriving_at": "2020-06-13T11:38:02",
                     "duration": "PT02H26M",
                     "id": "sto_00009htYpSCXrwaB9Dn456"
                   }

tests/test_partial_offer_requests.py

@@ -20,6 +20,8 @@ def test_get_partial_offer_request_by_id(requests_mock):
         offer = offer_request.offers[0]
         assert offer.partial
         assert offer.id == "off_00009htYpSCXrwaB9DnUm0"
+        assert offer.slices[0].segments[0].id == "seg_00009htYpSCXrwaB9Dn456"
+        assert offer.slices[0].segments[0].stops[0].id == "sto_00009htYpSCXrwaB9Dn456"
 
 
 def test_create_partial_offer_request(requests_mock):