feat: Require destination address for alias deletion

Modified the alias deletion process to require both the source and destination addresses.

Changes include:
- Updated backend API endpoint and logic for alias deletion.
- Updated frontend service call, component logic, and confirmation message for alias deletion.
- Removed unused translation key 'status' from account management.

Author: dunaj-dev

backend/dockerMailserver.js

@@ -237,12 +237,12 @@ async function addAlias(source, destination) {
 }
 
 // Function to delete an alias
-async function deleteAlias(source) {
+async function deleteAlias(source, destination) {
   try {
-    debugLog(`Deleting alias: ${source}`);
-    await execSetup(`alias del ${source}`);
-    debugLog(`Alias deleted: ${source}`);
-    return { success: true, source };
+    debugLog(`Deleting alias: ${source} => ${destination}`);
+    await execSetup(`alias del ${source} ${destination}`);
+    debugLog(`Alias deleted: ${source} => ${destination}`);
+    return { success: true, source, destination };
   } catch (error) {
     console.error('Error deleting alias:', error);
     debugLog('Alias deletion error:', error);

backend/index.js

@@ -107,12 +107,16 @@ app.post('/api/aliases', async (req, res) => {
 // Endpoint for deleting an alias
 app.delete('/api/aliases/:source', async (req, res) => {
   try {
-    const { source } = req.params;
+    const { source, destination } = req.params;
     if (!source) {
       return res.status(400).json({ error: 'Source is required' });
     }
-    await dockerMailserver.deleteAlias(source);
-    res.json({ message: 'Alias deleted successfully', source });
+    
+    if (!destination) {
+      return res.status(400).json({ error: 'Destination is required' });
+    }
+    await dockerMailserver.deleteAlias(source, destination);
+    res.json({ message: 'Alias deleted successfully', source, destination });
   } catch (error) {
     res.status(500).json({ error: 'Unable to delete alias' });
   }

frontend/src/locales/en/translation.json

@@ -35,7 +35,6 @@
     "password": "Password",
     "newPassword": "New Password",
     "confirmPassword": "Confirm Password",
-    "status": "Status",
     "storage": "Storage Usage",
     "aliases": "Aliases",
     "actions": "Actions",
@@ -54,11 +53,7 @@
     "cannotCreateAccount": "Unable to create account. Please try again.",
     "cannotDeleteAccount": "Unable to delete account. Please try again.",
     "cannotUpdatePassword": "Unable to update password. Please try again.",
-    "confirmDelete": "Are you sure you want to delete account {{email}}?",
-    "status": {
-      "active": "Active",
-      "inactive": "Inactive"
-    }
+    "confirmDelete": "Are you sure you want to delete account {{email}}?"
   },
   "aliases": {
     "title": "Aliases Management",
@@ -79,7 +74,7 @@
     "aliasDeleted": "Alias deleted successfully!",
     "cannotCreateAlias": "Unable to create alias. Please try again.",
     "cannotDeleteAlias": "Unable to delete alias. Please try again.",
-    "confirmDelete": "Are you sure you want to delete alias {{source}}?"
+    "confirmDelete": "Are you sure you want to delete alias {{source}} => {{destination}}?"
   },
   "settings": {
     "title": "Settings",

frontend/src/locales/pl/translation.json

@@ -35,7 +35,6 @@
     "password": "Hasło",
     "newPassword": "Nowe Hasło",
     "confirmPassword": "Potwierdź Hasło",
-    "status": "Status",
     "storage": "Użycie Dysku",
     "aliases": "Aliasy",
     "actions": "Akcje",
@@ -54,11 +53,7 @@
     "cannotCreateAccount": "Nie można utworzyć konta. Spróbuj ponownie.",
     "cannotDeleteAccount": "Nie można usunąć konta. Spróbuj ponownie.",
     "cannotUpdatePassword": "Nie można zaktualizować hasła. Spróbuj ponownie.",
-    "confirmDelete": "Czy na pewno chcesz usunąć konto {{email}}?",
-    "status": {
-      "active": "Aktywne",
-      "inactive": "Nieaktywne"
-    }
+    "confirmDelete": "Czy na pewno chcesz usunąć konto {{email}}?"
   },
   "aliases": {
     "title": "Zarządzanie Aliasami",
@@ -79,7 +74,7 @@
     "aliasDeleted": "Alias został pomyślnie usunięty!",
     "cannotCreateAlias": "Nie można utworzyć aliasu. Spróbuj ponownie.",
     "cannotDeleteAlias": "Nie można usunąć aliasu. Spróbuj ponownie.",
-    "confirmDelete": "Czy na pewno chcesz usunąć alias {{source}}?"
+    "confirmDelete": "Czy na pewno chcesz usunąć alias {{source}} => {{destination}}?"
   },
   "settings": {
     "title": "Ustawienia",

frontend/src/pages/Aliases.js

@@ -104,10 +104,10 @@ const Aliases = () => {
     }
   };
 
-  const handleDelete = async (source) => {
-    if (window.confirm(t('aliases.confirmDelete', { source }))) {
+  const handleDelete = async (source, destination) => {
+    if (window.confirm(t('aliases.confirmDelete', { source, destination }))) {
       try {
-        await deleteAlias(source);
+        await deleteAlias(source, destination);
         setSuccessMessage('aliases.aliasDeleted');
         fetchData(); // Refresh the aliases list
       } catch (err) {
@@ -127,7 +127,7 @@ const Aliases = () => {
           variant="danger"
           size="sm"
           icon="trash"
-          onClick={() => handleDelete(alias.source)}
+          onClick={() => handleDelete(alias.source, alias.destination)}
         />
       )
     }

frontend/src/services/api.js

@@ -83,9 +83,9 @@ export const addAlias = async (source, destination) => {
   }
 };
 
-export const deleteAlias = async (source) => {
+export const deleteAlias = async (source, destination) => {
   try {
-    const response = await api.delete(`/aliases/${source}`);
+    const response = await api.delete(`/aliases/${source}/${destination}`);
     return response.data;
   } catch (error) {
     console.error('Error deleting alias:', error);