[7.x] Fix use_shipping_address_for_billing option when using Database Orders (#1213)

* Fix to setting Order use_shipping_address_for_billing in eloquent

This appears to happen before the casts() method and if the value
property on the html element hydrating this is set to anything other
than "true" this was setting this to bool false.

IIRC the default for HTML checkbox inputs is the string "on" if
checked and "off" if not.

* Add failing test

* Keep the `== 'true'` check

* Also, value should be true when value is "on"

---------

Co-authored-by: Duncan McClean <duncan@duncanmcclean.com>

Author: leon-fablr

src/Orders/EloquentOrderRepository.php

@@ -171,7 +171,7 @@ public function save($order): void
         $model->billing_region = $order->get('billing_region');
         $model->billing_country = $order->get('billing_country');
 
-        $model->use_shipping_address_for_billing = $order->get('use_shipping_address_for_billing') == 'true';
+        $model->use_shipping_address_for_billing = $order->get('use_shipping_address_for_billing') == 'true' || $order->get('use_shipping_address_for_billing') == 'on';
 
         // If anything in the order data has it's own column, save it
         // there, rather than in the data column.

tests/Orders/EloquentOrderRepositoryTest.php

@@ -349,6 +349,32 @@
     ]);
 });
 
+it('can save use_shipping_address_for_billing column', function () {
+    $orderRecord = OrderModel::create();
+    $order = Order::find($orderRecord->id);
+
+    $order->set('use_shipping_address_for_billing', true)->save();
+    $this->assertDatabaseHas('orders', ['id' => $orderRecord->id, 'use_shipping_address_for_billing' => true]);
+
+    $order->set('use_shipping_address_for_billing', 'true')->save();
+    $this->assertDatabaseHas('orders', ['id' => $orderRecord->id, 'use_shipping_address_for_billing' => true]);
+
+    $order->set('use_shipping_address_for_billing', 'on')->save();
+    $this->assertDatabaseHas('orders', ['id' => $orderRecord->id, 'use_shipping_address_for_billing' => true]);
+
+    $order->set('use_shipping_address_for_billing', false)->save();
+    $this->assertDatabaseHas('orders', ['id' => $orderRecord->id, 'use_shipping_address_for_billing' => false]);
+
+    $order->set('use_shipping_address_for_billing', 'false')->save();
+    $this->assertDatabaseHas('orders', ['id' => $orderRecord->id, 'use_shipping_address_for_billing' => false]);
+
+    $order->set('use_shipping_address_for_billing', 'off')->save();
+    $this->assertDatabaseHas('orders', ['id' => $orderRecord->id, 'use_shipping_address_for_billing' => false]);
+
+    $order->set('use_shipping_address_for_billing', null)->save();
+    $this->assertDatabaseHas('orders', ['id' => $orderRecord->id, 'use_shipping_address_for_billing' => false]);
+});
+
 it('can save order with status log events', function () {
     $product = Product::make()->price(1000);
     $product->save();