Send a notification on order placed via gateway

[AurelienLab]

Hi !

I'm currently working on notifications during checkout process. I couldn't get to send a notification during a stripe payment (no callback on local environment), and while investigating, I found out that the status in the GatewayCallbackController is updated via $order->status(OrderStatus::Placed)->save(); and not with the updateOrderStatus() method.

simple-commerce/src/Http/Controllers/GatewayCallbackController.php

Line 47 in b832b87

$order->status(OrderStatus::Placed)->save();

I can imagine why (not sending a notification of order placed then a notification of order paid quickly after), but I wondered if it would be interesting to offer this option in configuration ?

If so, I could work on it with pleasure.

[duncanmcclean]

Have you setup the Stripe webhook? I believe it's responsible for calling the code that dispatches the relevant events.

[AurelienLab]

I did, but of course my local environment is not reachable from outside.
The thing is that the e-commerce isn't a priority for our client and we wanted to send an email on order placed, even without a payment. Then the admin would be notified of each order, even if there is a problem with the payment (stripe or webhook failure) and contact us if so.

In the current scenario, a failed payment will not trigger any notification to anyone when the order is completed.

That's why I thought it could be an interesting feature !

Also, thank you for the great job on the plugin @duncanmcclean !

[duncanmcclean]

I think the GatewayCallbackController might be bypassing the updateOrderStatus event on purpose, so the OrderPlaced event doesn't get sent multiple times (when the customer is redirected after checkout and when the webhook is received).

Maybe you could listen to the OrderSaved event instead, check if the status changed, and if it does, and you haven't already sent an email, you send one to your admins.

A new major version of Simple Commerce is on its way (an will be out soon, and it'll be released alongside Statamic 6), so I'm a bit weary changing things that could break things for others.