Skip to content

Commit adeb28e

Browse files
test: remove useless await (obs-websocket-community-projects#190)
Constructors cannot be async, so putting an `await` in front of `new WebSocket.Server` does nothing. So, I removed it. Since this was the only `await` present in `makeServer()`, I was able to remove the `async` from this method entirely. It does not seem to negatively impact the tests at all.
1 parent 3b48593 commit adeb28e

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

test/auth.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ let authServer;
88

99
const password = 'supersecretpassword';
1010

11-
test.before(async () => {
12-
unauthServer = await env.makeServer(4444);
13-
authServer = await env.makeServer(4443);
11+
test.before(() => {
12+
unauthServer = env.makeServer(4444);
13+
authServer = env.makeServer(4443);
1414

1515
const salt = 'PZVbYpvAnZut2SS6JNJytDm9';
1616
const challenge = 'ztTBnnuqrqaKDzRM3xcVdbYm';

test/events.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ let unauthServer;
66
const obs = new OBSWebSocket();
77

88
test.before(async t => {
9-
unauthServer = await env.makeServer(4446);
9+
unauthServer = env.makeServer(4446);
1010
await t.notThrowsAsync(obs.connect({
1111
address: 'localhost:4446'
1212
}));

test/requests.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ let unauthServer;
66
const obs = new OBSWebSocket();
77

88
test.before(async t => {
9-
unauthServer = await env.makeServer(4445);
9+
unauthServer = env.makeServer(4445);
1010
await t.notThrowsAsync(obs.connect({
1111
address: 'localhost:4445'
1212
}));

test/setup/environment.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ const onMessage = function (server, message) {
1919
return JSON.stringify(reply);
2020
};
2121

22-
async function makeServer(port) {
23-
const server = await new WebSocket.Server({port}, err => {
22+
function makeServer(port) {
23+
const server = new WebSocket.Server({port}, err => {
2424
if (err) {
2525
throw err;
2626
}

0 commit comments

Comments
 (0)