Skip to content

Commit 79f5905

Browse files
committed
fix append test for lower python versions
1 parent 52e86ca commit 79f5905

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

tests/unit/test_file.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import os
2+
import sys
23
import unittest
34

45
from dune_client.file.base import CSVFile, NDJSONFile, JSONFile
@@ -151,8 +152,17 @@ def test_not_skip_empty_when_specified(self):
151152
# CSV empty files won't have any headers!
152153
self.file_manager._write([], writer, False)
153154
else:
154-
with self.assertNoLogs():
155+
if sys.version_info < (3, 10):
156+
with self.assertRaises(FileNotFoundError):
157+
self.file_manager._load(writer)
158+
# assertNoLogs didn't exist till python 3.10, but we still support lower versions.
159+
# This is a bit of a hack, we write and then load to ensure the empty file was written.
155160
self.file_manager._write([], writer, False)
161+
# _load would return FileNotFoundError if it hadn't been written
162+
self.assertEqual(0, len(self.file_manager._load(writer)))
163+
else:
164+
with self.assertNoLogs():
165+
self.file_manager._write([], writer, False)
156166

157167
self.file_manager._load(writer)
158168

0 commit comments

Comments
 (0)