Skip to content

Commit aef5949

Browse files
authored
bugfixes: create_query is_private field name & add optional arguments to run_sql() (#103)
* create_query(): fix argument, field is is_private, not private * run_sql(): add optional argument to specify performance * run_sql(): add optional argument to name the query * bump max args to 10 on lint rules
1 parent ac29a0f commit aef5949

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

.pylintrc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
[MASTER]
2-
disable=fixme,logging-fstring-interpolation
2+
disable=fixme,logging-fstring-interpolation
3+
[DESIGN]
4+
max-args=10

dune_client/api/extensions.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,15 +195,17 @@ def run_sql(
195195
params: Optional[list[QueryParameter]] = None,
196196
is_private: bool = True,
197197
archive_after: bool = True,
198+
performance: Optional[str] = None,
199+
name: str = "API Query",
198200
) -> ResultsResponse:
199201
"""
200202
Allows user to provide execute raw_sql via the CRUD interface
201203
- create, run, get results with optional archive/delete.
202204
- Query is by default made private and archived after execution.
203205
Requires premium subscription!
204206
"""
205-
query = self.create_query("API Query", query_sql, params, is_private)
206-
results = self.run_query(query.base)
207+
query = self.create_query(name, query_sql, params, is_private)
208+
results = self.run_query(query=query.base, performance=performance)
207209
if archive_after:
208210
self.archive_query(query.base.query_id)
209211
return results

dune_client/api/query.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def create_query(
3333
payload = {
3434
"name": name,
3535
"query_sql": query_sql,
36-
"private": is_private,
36+
"is_private": is_private,
3737
}
3838
if params is not None:
3939
payload["parameters"] = [p.to_dict() for p in params]

0 commit comments

Comments
 (0)