Skip to content

Commit f4828da

Browse files
authored
[Easy] Cleanup (#65)
* pre-cleanup before bigger changes * rename error in test
1 parent 48343d5 commit f4828da

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

dune_client/client.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -364,15 +364,13 @@ def unarchive_query(self, query_id: int) -> bool:
364364
def make_private(self, query_id: int) -> None:
365365
"""
366366
https://dune.com/docs/api/api-reference/edit-queries/private-query
367-
returns resulting value of Query.is_private
368367
"""
369368
response_json = self._post(route=f"/query/{query_id}/private")
370369
assert self.get_query(int(response_json["query_id"])).meta.is_private
371370

372371
def make_public(self, query_id: int) -> None:
373372
"""
374373
https://dune.com/docs/api/api-reference/edit-queries/private-query
375-
returns resulting value of Query.is_private
376374
"""
377375
response_json = self._post(route=f"/query/{query_id}/unprivate")
378376
assert not self.get_query(int(response_json["query_id"])).meta.is_private

tests/e2e/test_client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ def test_internal_error(self):
151151
dune.execute(query)
152152
self.assertEqual(
153153
str(err.exception),
154-
"Can't build ExecutionResponse from {'error': 'Query not found'}",
154+
"Can't build ExecutionResponse from {'error': 'An internal error occured'}",
155155
)
156156

157157
def test_invalid_job_id_error(self):
@@ -176,6 +176,7 @@ def test_get_latest_result_with_query_id(self):
176176
self.assertGreater(len(results), 0)
177177

178178

179+
@unittest.skip("This is an enterprise only endpoint that can no longer be tested.")
179180
class TestCRUDOps(unittest.TestCase):
180181
def setUp(self) -> None:
181182
dotenv.load_dotenv()

0 commit comments

Comments
 (0)