feat(amazonq): implement displayFindings tool (aws#2029)

* feat(amazonq): implement displayFindings tool

* feat(amazonq): add unit tests for display findings tool

* fix(amazonq): simplify displayFindings unit tests, collapse switch statement

* fix(amazonq): emit metrics for displayFindings, fix error handling, improve unit tests

Author: BlakeLazarine

server/aws-lsp-codewhisperer/src/language-server/agenticChat/agenticChatController.ts

@@ -201,7 +201,10 @@ import { URI } from 'vscode-uri'
 import { CommandCategory } from './tools/executeBash'
 import { UserWrittenCodeTracker } from '../../shared/userWrittenCodeTracker'
 import { CodeReview } from './tools/qCodeAnalysis/codeReview'
-import { FINDINGS_MESSAGE_SUFFIX } from './tools/qCodeAnalysis/codeReviewConstants'
+import {
+    CODE_REVIEW_FINDINGS_MESSAGE_SUFFIX,
+    DISPLAY_FINDINGS_MESSAGE_SUFFIX,
+} from './tools/qCodeAnalysis/codeReviewConstants'
 import { McpEventHandler } from './tools/mcp/mcpEventHandler'
 import { enabledMCP, createNamespacedToolName } from './tools/mcp/mcpUtils'
 import { McpManager } from './tools/mcp/mcpManager'
@@ -225,6 +228,7 @@ import { getLatestAvailableModel } from './utils/agenticChatControllerHelper'
 import { ActiveUserTracker } from '../../shared/activeUserTracker'
 import { UserContext } from '../../client/token/codewhispererbearertokenclient'
 import { CodeWhispererServiceToken } from '../../shared/codeWhispererService'
+import { DisplayFindings } from './tools/qCodeAnalysis/displayFindings'
 
 type ChatHandlers = Omit<
     LspHandlers<Chat>,
@@ -1764,7 +1768,8 @@ export class AgenticChatController implements ChatHandlers {
                         break
                     }
                     case CodeReview.toolName:
-                        // no need to write tool message for code review
+                    case DisplayFindings.toolName:
+                        // no need to write tool message for CodeReview or DisplayFindings
                         break
                     // — DEFAULT ⇒ Only MCP tools, but can also handle generic tool execution messages
                     default:
@@ -1940,11 +1945,27 @@ export class AgenticChatController implements ChatHandlers {
                         ) {
                             await chatResultStream.writeResultBlock({
                                 type: 'tool',
-                                messageId: toolUse.toolUseId + FINDINGS_MESSAGE_SUFFIX,
+                                messageId: toolUse.toolUseId + CODE_REVIEW_FINDINGS_MESSAGE_SUFFIX,
                                 body: (codeReviewResult.output.content as any).findingsByFile,
                             })
                         }
                         break
+                    case DisplayFindings.toolName:
+                        // no need to write tool result for code review, this is handled by model via chat
+                        // Push result in message so that it is picked by IDE plugin to show in issues panel
+                        const displayFindingsResult = result as InvokeOutput
+                        if (
+                            displayFindingsResult?.output?.kind === 'json' &&
+                            displayFindingsResult.output.success &&
+                            displayFindingsResult.output.content !== undefined
+                        ) {
+                            await chatResultStream.writeResultBlock({
+                                type: 'tool',
+                                messageId: toolUse.toolUseId + DISPLAY_FINDINGS_MESSAGE_SUFFIX,
+                                body: JSON.stringify(displayFindingsResult.output.content),
+                            })
+                        }
+                        break
                     // — DEFAULT ⇒ MCP tools
                     default:
                         await this.#handleMcpToolResult(toolUse, result, session, chatResultStream)

server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/qCodeAnalysis/codeReviewConstants.ts

@@ -211,6 +211,7 @@ export const SKIP_DIRECTORIES = [
     'temp',
 ]
 
-export const FINDINGS_MESSAGE_SUFFIX = '_codeReviewFindings'
+export const CODE_REVIEW_FINDINGS_MESSAGE_SUFFIX = '_codeReviewFindings'
+export const DISPLAY_FINDINGS_MESSAGE_SUFFIX = '_displayFindings'
 
 export const CODE_REVIEW_METRICS_PARENT_NAME = 'amazonq_codeReviewTool'

server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/qCodeAnalysis/codeReviewUtils.ts

@@ -278,6 +278,18 @@ export class CodeReviewUtils {
         return qCapabilities?.codeReviewInChat || false
     }
 
+    /**
+     * Check if storing display findings in the Code Issues panel is enabled.
+     * @param params Initialize parameters from client
+     * @returns True if display findings is enabled, false otherwise
+     */
+    public static isDisplayFindingsEnabled(params: InitializeParams | undefined): boolean {
+        const qCapabilities = params?.initializationOptions?.aws?.awsClientCapabilities?.q as
+            | QClientCapabilities
+            | undefined
+        return qCapabilities?.displayFindings || false
+    }
+
     /**
      * Converts a Windows absolute file path to Unix format and removes the drive letter
      * @param windowsPath The Windows path to convert