fix: array join

Author: ZeRiix

scripts/array/join.ts

@@ -6,11 +6,14 @@ import { type ShiftTuple } from "./types";
 type ComputeResult<
 	GenericArray extends readonly string[],
 	GenericSeparator extends string,
-> = GenericArray extends AnyTuple
-	? IsEqual<GenericArray["length"], 1> extends true
-		? GenericArray[0]
-		: `${GenericArray[0]}${GenericSeparator}${ComputeResult<Adaptor<ShiftTuple<GenericArray>, readonly string[]>, GenericSeparator>}`
-	: string;
+	Depth extends readonly unknown[] = [],
+> = Depth["length"] extends 50
+	? string
+	: GenericArray extends AnyTuple
+		? IsEqual<GenericArray["length"], 1> extends true
+			? GenericArray[0]
+			: `${GenericArray[0]}${GenericSeparator}${ComputeResult<Adaptor<ShiftTuple<GenericArray>, readonly string[]>, GenericSeparator, [...Depth, 0]>}`
+		: string;
 
 export function join<
 	GenericArray extends readonly string[],

tests/array/join.test.ts

@@ -2,12 +2,9 @@ import { type ExpectType, pipe, toString } from "@scripts/common";
 import { DArray } from "@scripts";
 
 describe("join", () => {
-	it("joins array with separator", () => {
-		expect(DArray.join(["1", "2", "3"], ",")).toBe("1,2,3");
-	});
-
-	it("joins const array with separator", () => {
-		const result = DArray.join(["1", "2", "3"] as const, "-");
+	it("join tuple with separator", () => {
+		const input = ["1", "2", "3"] as const;
+		const result = DArray.join(input, "-");
 
 		expect(result).toBe("1-2-3");
 
@@ -18,12 +15,31 @@ describe("join", () => {
 		>;
 	});
 
-	it("joins array using pipe with separator", () => {
+	it("join array with separator", () => {
+		const input = ["a", "b", "c"];
+		const result = DArray.join(input, "-");
+
+		expect(result).toBe("a-b-c");
+
+		type check = ExpectType<
+			typeof result,
+			string,
+			"strict"
+		>;
+	});
+
+	it("join array using pipe with separator", () => {
 		const result = pipe(
 			[1, 2, 3],
 			DArray.map(toString),
 			DArray.join("-"),
 		);
 		expect(result).toBe("1-2-3");
+
+		type check = ExpectType<
+			typeof result,
+			string,
+			"strict"
+		>;
 	});
 });