Skip to content

Commit 9352f7f

Browse files
committed
cmd-diff: fix superfluous .stdout call
The .stdout at the end of this line is unnecessary and has no effect. When stdout is redirected to a file object, the stdout attribute of the returned CompletedProcess object is None. Assisted-By <gemini-code-assist> coreos#4253 (comment)
1 parent 8c1ba13 commit 9352f7f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/cmd-diff

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ def diff_cmd_outputs(cmd, path_from, path_to, strategy='template'):
442442
else:
443443
assert strategy == 'cd'
444444
workingdir = path
445-
subprocess.run(c, cwd=workingdir, check=True, stdout=output).stdout
445+
subprocess.run(c, cwd=workingdir, check=True, stdout=output)
446446
git_diff(from_output.name, to_output.name)
447447

448448

0 commit comments

Comments
 (0)