Skip to content

Commit 962012f

Browse files
committed
cmd-diff: fix superfluous .stdout call
The .stdout at the end of this line is unnecessary and has no effect. When stdout is redirected to a file object, the stdout attribute of the returned CompletedProcess object is None. Assisted-By <gemini-code-assist> coreos#4253 (comment)
1 parent a9e3a95 commit 962012f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/cmd-diff

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,7 @@ def diff_cmd_outputs(cmd, path_from, path_to, strategy: DiffCmdOutputStrategy =
446446
c[idx] = path
447447
elif strategy == DiffCmdOutputStrategy.CD:
448448
workingdir = path
449-
subprocess.run(c, cwd=workingdir, check=True, stdout=output).stdout
449+
subprocess.run(c, cwd=workingdir, check=True, stdout=output)
450450
git_diff(from_output.name, to_output.name)
451451

452452

0 commit comments

Comments
 (0)