consider length of string keys (#308)

mdrossmiller · web-flow · commit b5dbdd88cc7c · 2024-10-29T09:56:45.000+01:00
Prevent str_set comparison from accepting prefix as false positive
diff --git a/external/hash/str_set.c b/external/hash/str_set.c
@@ -47,7 +47,7 @@ DEFINE_HASH_TABLE(str_set)
  */
 static inline int ht_match(const void *key, size_t len, str_set_item_t item)
 {
-    return strncmp(key, item, len) == 0;
+    return strncmp(key, item, len) == 0 && item[len] == '\0';
 }
 
 static inline const void *ht_key(str_set_item_t item)

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ DEFINE_HASH_TABLE(str_set)`
`47`	`47`	`*/`
`48`	`48`	`static inline int ht_match(const void *key, size_t len, str_set_item_t item)`
`49`	`49`	`{`
`50`		`- return strncmp(key, item, len) == 0;`
	`50`	`+ return strncmp(key, item, len) == 0 && item[len] == '\0';`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`static inline const void *ht_key(str_set_item_t item)`