Skip to content

Commit d8ddb2c

Browse files
committed
Fix type in print formatting
1 parent c4c99fe commit d8ddb2c

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
using the str_set table for other purposes. (#308).
5959
- Fix some GCC indentation warnings in generated code - warnings are
6060
disabled in build already, but this may help some users (#313).
61+
- Fix %d vs uint32 type in some printformatting (#315).
6162

6263
## [0.6.1]
6364

src/compiler/codegen_c_json_printer.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -301,8 +301,8 @@ static int gen_json_printer_struct(fb_output_t *out, fb_compound_type_t *ct)
301301
tp = scalar_type_prefix(member->type.st);
302302
fprintf(
303303
out->fp,
304-
" flatcc_json_printer_%s_array_struct_field(ctx, %d, p, %"PRIu64", \"%.*s\", %ld, %d);\n",
305-
tp, index, (uint64_t)member->offset, (int)sym->ident->len, sym->ident->text, sym->ident->len, member->type.len);
304+
" flatcc_json_printer_%s_array_struct_field(ctx, %d, p, %"PRIu64", \"%.*s\", %ld, %"PRIu64");\n",
305+
tp, index, (uint64_t)member->offset, (int)sym->ident->len, sym->ident->text, sym->ident->len, (uint64_t)member->type.len);
306306
break;
307307
case vt_fixed_array_compound_type_ref:
308308
fb_compound_name(member->type.ct, &snref);
@@ -311,8 +311,8 @@ static int gen_json_printer_struct(fb_output_t *out, fb_compound_type_t *ct)
311311
#if FLATCC_JSON_PRINT_MAP_ENUMS
312312
tp = scalar_type_prefix(member->type.ct->type.st);
313313
fprintf(out->fp,
314-
" flatcc_json_printer_%s_enum_array_struct_field(ctx, %d, p, %"PRIu64", \"%.*s\", %ld, %d, %s_print_json_enum);\n",
315-
tp, index, (uint64_t)member->offset, (int)sym->ident->len, sym->ident->text, sym->ident->len, member->type.len, snref.text);
314+
" flatcc_json_printer_%s_enum_array_struct_field(ctx, %d, p, %"PRIu64", \"%.*s\", %ld, %"PRIu64", %s_print_json_enum);\n",
315+
tp, index, (uint64_t)member->offset, (int)sym->ident->len, sym->ident->text, sym->ident->len, (uint64_t)member->type.len, snref.text);
316316
break;
317317
#else
318318
tp = scalar_type_prefix(member->type.ct->type.st);

src/compiler/codegen_c_reader.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1294,8 +1294,8 @@ static void gen_struct(fb_output_t *out, fb_compound_type_t *ct)
12941294
tname = scalar_type_name(member->type.st);
12951295
tname_prefix = scalar_type_prefix(member->type.st);
12961296
fprintf(out->fp,
1297-
"__%sdefine_struct_scalar_fixed_array_field(%s, %.*s, %s%s, %s%s, %d)\n",
1298-
nsc, snt.text, n, s, nsc, tname_prefix, tname_ns, tname, member->type.len);
1297+
"__%sdefine_struct_scalar_fixed_array_field(%s, %.*s, %s%s, %s%s, %"PRIu64")\n",
1298+
nsc, snt.text, n, s, nsc, tname_prefix, tname_ns, tname, (uint64_t)member->type.len);
12991299
/* TODO: if member->type.st == fb_char add string specific methods. */
13001300
break;
13011301
case vt_scalar_type:
@@ -1344,13 +1344,13 @@ static void gen_struct(fb_output_t *out, fb_compound_type_t *ct)
13441344
switch (member->type.ct->symbol.kind) {
13451345
case fb_is_enum:
13461346
fprintf(out->fp,
1347-
"__%sdefine_struct_scalar_fixed_array_field(%s, %.*s, %s, %s_enum_t, %d)\n",
1348-
nsc, snt.text, n, s, snref.text, snref.text, member->type.len);
1347+
"__%sdefine_struct_scalar_fixed_array_field(%s, %.*s, %s, %s_enum_t, %"PRIu64")\n",
1348+
nsc, snt.text, n, s, snref.text, snref.text, (uint64_t)member->type.len);
13491349
break;
13501350
case fb_is_struct:
13511351
fprintf(out->fp,
1352-
"__%sdefine_struct_struct_fixed_array_field(%s, %.*s, %s_struct_t, %d)\n",
1353-
nsc, snt.text, n, s, snref.text, member->type.len);
1352+
"__%sdefine_struct_struct_fixed_array_field(%s, %.*s, %s_struct_t, %"PRIu64")\n",
1353+
nsc, snt.text, n, s, snref.text, (uint64_t)member->type.len);
13541354
break;
13551355
}
13561356
break;

0 commit comments

Comments
 (0)