[TSAR, CanonicalLoop] Fix, induction variable may be global.

Author: kaniandr

lib/Analysis/Clang/CanonicalLoop.cpp

@@ -414,9 +414,10 @@ class CanonicalLoopLabeler : public MatchFinder::MatchCallback {
           std::get<4>(Tuple) = &U;
         }
       } else if (isa<ConstantData>(Op) || isa<GlobalValue>(Op)) {
+        if (!InductIdx.count(Op.getOperandNo())) {
           std::get<3>(Tuple) = Op;
           std::get<4>(Tuple) = &U;
-      } else if (auto Expr = dyn_cast<llvm::ConstantExpr>(Op)) {
+        }
       } else {
         std::get<0>(Tuple) = false;
         return Tuple;

test/analysis/canonical_loop/check

@@ -18,3 +18,4 @@ canonical_loop_17
 canonical_loop_18
 global_1
 global_2
+global_3

test/analysis/canonical_loop/global_3.c

@@ -0,0 +1,6 @@
+int I;
+void foo() {
+  for (I = 0; I < 10; ++I);
+}
+//CHECK: Printing analysis 'Canonical Form Loop Analysis' for function 'foo':
+//CHECK: loop at global_3.c:3:3 is semantically canonical

test/analysis/canonical_loop/global_3.conf

@@ -0,0 +1,5 @@
+plugin = TsarPlugin
+
+sample = $name.c
+options = -print-only=canonical-loop -print-filename -use-analysis-server
+run = "$tsar $sample $options"

test/analysis/canonical_loop/init

@@ -18,3 +18,4 @@ canonical_loop_17: action=init
 canonical_loop_18: action=init
 global_1: action=init
 global_2: action=init
+global_3: action=init