add test for GogsHttp.get/1 via Gogs.HTTPoisonMock.get/2 for #1

Author: nelsonic

lib/http.ex

@@ -6,7 +6,6 @@ defmodule GogsHttp do
   If anything is unclear, please open an issue: 
   [github.com/dwyl/**gogs/issues**](https://github.com/dwyl/gogs/issues)
   """
-  import GogsHelpers
   require Logger
 
   @access_token Envar.get("GOGS_ACCESS_TOKEN")
@@ -34,7 +33,7 @@ defmodule GogsHttp do
   def parse_body_response({:error, err}), do: {:error, err}
 
   def parse_body_response({:ok, response}) do
-    Logger.debug(response)
+    # Logger.debug(response)
     body = Map.get(response, :body)
     if body == nil || byte_size(body) == 0 do
       Logger.warning("GogsHttp.parse_body_response: response body is nil!")
@@ -55,7 +54,7 @@ defmodule GogsHttp do
   @spec get(String.t()) :: {:ok, map} | {:error, any}
   def get(url) do
     Logger.info("GogsHttp.get #{url}")
-    inject_poison().get(url, @headers) |> IO.inspect()
+    inject_poison().get(url, @headers)
     |> parse_body_response()
   end
 

lib/httpoison_mock.ex

@@ -13,8 +13,8 @@ defmodule Gogs.HTTPoisonMock do
   @remote_repo_create_response_body %{
     clone_url: "https://gogs-server.fly.dev/myorg/replacethis.git",
     # created_at: "0001-01-01T00:00:00Z",
-    default_branch: "",
-    description: "replacethis",
+    # default_branch: "public-repo",
+    # description: "replacethis",
     empty: false,
     fork: false,
     forks_count: 0,
@@ -39,19 +39,19 @@ defmodule Gogs.HTTPoisonMock do
     ssh_url: "ssh://[email protected]:10022/myorg/replacethis.git",
     stars_count: 0,
     # updated_at: "0001-01-01T00:00:00Z",
-    watchers_count: 0,
+    # watchers_count: 0,
     website: ""
   }
 
   # make a valid response body for testing
   def make_repo_create_post_response_body(repo_name) do
     Map.merge(@remote_repo_create_response_body, %{
       clone_url: "https://gogs-server.fly.dev/myorg/#{repo_name}.git",
-      description: repo_name,
+      # description: repo_name,
       full_name: "myorg/#{repo_name}",
       html_url: "https://gogs-server.fly.dev/myorg/#{repo_name}",
       ssh_url: "ssh://[email protected]:10022/myorg/#{repo_name}.git",
-      readme: repo_name,
+      # readme: repo_name,
       name: repo_name
     })
   end
@@ -62,8 +62,9 @@ defmodule Gogs.HTTPoisonMock do
   """
   def get(url, _headers) do
     Logger.debug("Gogs.HTTPoisonMock.get/2 #{url}")
+    repo_name = GogsHelpers.get_repo_name_from_url(url)
     response_body = 
-      make_repo_create_post_response_body("tbd")
+      make_repo_create_post_response_body(repo_name)
       |> Jason.encode!()
     {:ok, %{body: response_body}}
   end

test/gogshttp_test.exs

@@ -11,11 +11,15 @@ defmodule GogsHttpTest do
     res = %{body: ""}
     assert GogsHttp.parse_body_response({:ok, res}) == {:error, :no_body}
   end
-  
-  test "GogsHttp.get/1 gets (or mocks) an HTTP GET request to Gogs Server" do
-    url = "https://gogs-server.fly.dev/api/v1/repos/nelsonic/public-repo"
-    {:ok, res} = GogsHttp.get(url)
 
-    assert true == true
+  test "GogsHttp.get/1 gets (or mocks) an HTTP GET request to Gogs Server" do
+    repo_name = "public-repo"
+    url = "https://gogs-server.fly.dev/api/v1/repos/myorg/#{repo_name}"
+    {:ok, response} = GogsHttp.get(url)
+    # remove unpredictable fields from response when mock:false
+    drop_fields = ~w(created_at default_branch description id readme updated_at watchers_count)a
+    response = Map.drop(response, drop_fields)
+    mock_response = Gogs.HTTPoisonMock.make_repo_create_post_response_body(repo_name)
+    assert response == mock_response
   end
 end