Skip to content
This repository was archived by the owner on Mar 18, 2024. It is now read-only.

Commit 1661d4a

Browse files
author
azlam-abdulsalam
committed
fix(analyzer): 🐛 add a getName to display the analyzer being used
remove the incorrect json stringify on isEnabled and display analzyer
1 parent 73bcd12 commit 1661d4a

File tree

6 files changed

+30
-4
lines changed

6 files changed

+30
-4
lines changed

packages/core/src/package/analyser/FHTAnalyzer.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,13 @@ import { PackageAnalyzer } from './PackageAnalyzer';
77
import SFPLogger, { Logger, LoggerLevel } from '@dxatscale/sfp-logger';
88

99
export default class FHTAnalyser implements PackageAnalyzer {
10+
11+
public getName() {
12+
return "Field History Tracking Analyzer"
13+
}
14+
15+
16+
1017
public async analyze(sfpPackage: SfpPackage, componentSet:ComponentSet, logger:Logger): Promise<SfpPackage> {
1118
try {
1219

packages/core/src/package/analyser/FTAnalyzer.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ import { PackageAnalyzer } from './PackageAnalyzer';
77
import SFPLogger, { Logger, LoggerLevel } from '@dxatscale/sfp-logger';
88

99
export default class FTAnalyser implements PackageAnalyzer {
10+
11+
public getName(): string {
12+
return "Feed Tracking Analyzer";
13+
};
14+
1015
public async analyze(sfpPackage: SfpPackage, componentSet:ComponentSet, logger:Logger): Promise<SfpPackage> {
1116
try {
1217

packages/core/src/package/analyser/PackageAnalyzer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import SfpPackage from "../SfpPackage";
44

55
export interface PackageAnalyzer
66
{
7-
7+
getName();
88
analyze(sfpPackage: SfpPackage,componentSet:ComponentSet,logger:Logger): Promise<SfpPackage>
99
isEnabled(sfpPackage: SfpPackage,logger:Logger): Promise<boolean>
1010

packages/core/src/package/analyser/PicklistAnalyzer.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@ import { PackageAnalyzer } from './PackageAnalyzer';
44
import SFPLogger, { Logger, LoggerLevel } from '@dxatscale/sfp-logger';
55

66
export default class PicklistAnalyzer implements PackageAnalyzer {
7+
8+
public getName() {
9+
return "Field History Tracking Analyzer"
10+
}
11+
12+
13+
714
public async analyze(sfpPackage: SfpPackage, componentSet:ComponentSet, logger:Logger): Promise<SfpPackage> {
815
try {
916
let sourceComponents = componentSet.getSourceComponents().toArray();

packages/core/src/package/deploymentCustomizers/PicklistEnabler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ export default class PicklistEnabler implements DeploymentCustomizer {
8989
if (!isPickListIdentical) {
9090
this.deployPicklist(picklistInOrg, picklistValueSource, sfpOrg.getConnection(),logger);
9191
} else {
92-
SFPLogger.log(`Picklist for custom field ${picklistInOrg.fullName} is identical to the source.No deployment`, LoggerLevel.TRACE, logger);
92+
SFPLogger.log(`Picklist for custom field ${picklistInOrg.fullName} is identical to the source.No deployment`, LoggerLevel.INFO, logger);
9393
}
9494
}
9595

packages/core/src/package/packageInstallers/InstallPackage.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -363,8 +363,15 @@ export abstract class InstallPackage {
363363

364364
let analyzers = AnalyzerRegistry.getAnalyzers();
365365
for (const analyzer of analyzers) {
366-
SFPLogger.log(JSON.stringify(analyzer.isEnabled), LoggerLevel.INFO, this.logger);
367-
if(analyzer.isEnabled(this.sfpPackage, this.logger)) this.sfpPackage = await analyzer.analyze(this.sfpPackage,componentSet, this.logger);
366+
if(await analyzer.isEnabled(this.sfpPackage, this.logger))
367+
{
368+
SFPLogger.log(`Executing ${analyzer.getName()}`, LoggerLevel.INFO, this.logger);
369+
this.sfpPackage = await analyzer.analyze(this.sfpPackage,componentSet, this.logger);
370+
}
371+
else
372+
{
373+
SFPLogger.log(`Skipped ${analyzer.getName()}`, LoggerLevel.INFO, this.logger);
374+
}
368375
}
369376

370377
for (const preDeployer of PreDeployersRegistry.getPreDeployers()) {

0 commit comments

Comments
 (0)