Skip to content

Workflow issues: PR Review Responder retry logic exceeds maximumΒ #2776

@wwwillchen-bot

Description

@wwwillchen-bot

Workflow Health Report

Period: 2026-02-23T13:27:30Z to 2026-02-24T13:27:30Z
Total runs checked: 100
Failures found: 1 actionable, 5+ expected (ignored)

Issues Found

PR Review Responder exceeds retry limit

  • Workflow: PR Review Responder
  • Severity: MODERATE
  • Failed runs:
  • Error: Workflow attempts to add label cc:request:4 which doesn't exist. The retry logic calculates NEXT_COUNT = 4 (from REQUEST_COUNT=3 + 1) but the maximum retry count is 3.
  • Error message:
    REQUEST_COUNT="3"
    NEXT_COUNT=$(( ${REQUEST_COUNT:-0} + 1 ))
    echo "Setting cc:request:${NEXT_COUNT} to auto-re-request review (retry ${NEXT_COUNT} of 3)"
    gh pr edit 2749 --repo dyad-sh/dyad --remove-label "cc:pending" --add-label "cc:request:${NEXT_COUNT}"
    # Output: Setting cc:request:4 to auto-re-request review (retry 4 of 3)
    # Error: 'cc:request:4' not found
    
  • Suggested fix: Update the workflow logic to check if REQUEST_COUNT >= MAX_RETRIES before incrementing, and if so, skip to marking the PR as failed instead of trying to add a non-existent label. Alternatively, add logic like:
    MAX_RETRIES=3
    if [ "${REQUEST_COUNT:-0}" -ge "$MAX_RETRIES" ]; then
      echo "Max retries reached, marking as failed"
      gh pr edit --add-label "cc:failed"
    else
      NEXT_COUNT=$(( ${REQUEST_COUNT:-0} + 1 ))
      gh pr edit --add-label "cc:request:${NEXT_COUNT}"
    fi

Expected Failures (Ignored)

  • Nightly Runner Cleanup (1 failure) - Expected intentional failure as this workflow reboots runners
  • Playwright Report Comment (2 failures) - Cascading failures from missing CI artifacts when upstream CI fails/cancels
  • CI on PR branches (5+ failures) - Normal PR CI failures on contributor branches
  • Cancelled runs (1) - Normal concurrency group cancellations

This issue was automatically created by the daily workflow health check.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions