Fix link() creating unnecessary directories (#816)

dycw · web-flow · web-flow · commit 7835e39c8cc4 · 2026-02-21T09:32:07.000+09:00
Co-authored-by: github-actions-bot &lt;noreply@github.com&gt;
diff --git a/.bumpversion.toml b/.bumpversion.toml
diff --git a/configs/asciinema/set-up.sh b/configs/asciinema/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/bash/set-up.sh b/configs/bash/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${HOME}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${HOME}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/bat/set-up.sh b/configs/bat/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/batwatch/set-up.sh b/configs/batwatch/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/bottom/set-up.sh b/configs/bottom/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/curl/set-up.sh b/configs/curl/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/direnv/set-up.sh b/configs/direnv/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/eza/set-up.sh b/configs/eza/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/fd/set-up.sh b/configs/fd/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/fish/set-up.sh b/configs/fish/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/fzf/set-up.sh b/configs/fzf/set-up.sh
@@ -7,8 +7,9 @@ set -eu
 script_dir=$(dirname -- "$(realpath -- "$0")")
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	ln -sfn "$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "$1" "${dest}"
 }
 
 link_here() {
diff --git a/configs/ghostty/set-up.sh b/configs/ghostty/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/git/set-up.sh b/configs/git/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/hypothesis/set-up.sh b/configs/hypothesis/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/ipython/set-up.sh b/configs/ipython/set-up.sh
@@ -5,9 +5,9 @@ set -eu
 ###############################################################################
 
 link() {
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
 	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "$2"
+	ln -sfn "${src}" "$2"
 }
 
 ###############################################################################
diff --git a/configs/jupyter/set-up.sh b/configs/jupyter/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${HOME}/.jupyter/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${HOME}/.jupyter/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/neovim/set-up.sh b/configs/neovim/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/node/set-up.sh b/configs/node/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/pdb/set-up.sh b/configs/pdb/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${HOME}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${HOME}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/pgcli/set-up.sh b/configs/pgcli/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/postgres/set-up.sh b/configs/postgres/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/prek/set-up.sh b/configs/prek/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/psql/set-up.sh b/configs/psql/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${HOME}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${HOME}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/pudb/set-up.sh b/configs/pudb/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/pyright/set-up.sh b/configs/pyright/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/pytest/set-up.sh b/configs/pytest/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/python/set-up.sh b/configs/python/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/qrt-dotfiles/set-up.sh b/configs/qrt-dotfiles/set-up.sh
@@ -5,9 +5,10 @@ set -eu
 ###############################################################################
 
 link() {
-	mkdir -p "$(dirname -- "$2")"
-	script_dir=$(dirname -- "$(realpath -- "$0")")
-	ln -sfn "${script_dir}/$1" "${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	src="$(dirname -- "$(realpath -- "$0")")/$1"
+	dest="${XDG_CONFIG_HOME:-${HOME}/.config}/$2"
+	mkdir -p "$(dirname -- "${dest}")"
+	ln -sfn "${src}" "${dest}"
 }
 
 ###############################################################################
diff --git a/configs/ripgrep/set-up.sh b/configs/ripgrep/set-up.sh
diff --git a/configs/ruff/set-up.sh b/configs/ruff/set-up.sh
diff --git a/configs/shell/set-up.sh b/configs/shell/set-up.sh
diff --git a/configs/sops/set-up.sh b/configs/sops/set-up.sh
diff --git a/configs/starship/set-up.sh b/configs/starship/set-up.sh
diff --git a/configs/tailscale/set-up.sh b/configs/tailscale/set-up.sh
diff --git a/configs/tmux/set-up.sh b/configs/tmux/set-up.sh
diff --git a/configs/uv/set-up.sh b/configs/uv/set-up.sh
diff --git a/configs/vim/set-up.sh b/configs/vim/set-up.sh
diff --git a/configs/wezterm/set-up.sh b/configs/wezterm/set-up.sh
diff --git a/configs/zoxide/set-up.sh b/configs/zoxide/set-up.sh
