Remove skip_go feature flag and delete old code (#437)

* Fix issue on iOS 26 beta

* Fix issue on iOS 26 beta

* Remove skip_go feature flag and delete old code

* Clean up

Author: ruixhuang

dydx/dydxFormatter/dydxFormatter/_Utils/dydxFeatureFlag.swift

@@ -14,7 +14,6 @@ public enum dydxBoolFeatureFlag: String, CaseIterable {
     case enable_app_rating
     case showPredictionMarketsUI = "ff_show_prediction_markets_ui"
     case simple_ui = "ff_simple_ui"
-    case skip_go_fast = "ff_skip_go_fast"
     case privy_ios = "ff_privy_ios"
     case turnkey_ios = "ff_turnkey_ios"
 
@@ -28,8 +27,6 @@ public enum dydxBoolFeatureFlag: String, CaseIterable {
             return false
         case .simple_ui:
             return true
-        case .skip_go_fast:
-            return true
         case .privy_ios:
             return false
         case .turnkey_ios:

dydx/dydxPresenters/dydxPresenters.xcodeproj/project.pbxproj

@@ -31,7 +31,6 @@
 		0208627C28F4DAC000C9D3A0 /* dydxMarketInfoPagingViewPresenter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0208627B28F4DAC000C9D3A0 /* dydxMarketInfoPagingViewPresenter.swift */; };
 		0208631028F5186E00C9D3A0 /* OrderbookLineDataPoint.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0208630F28F5186E00C9D3A0 /* OrderbookLineDataPoint.swift */; };
 		0208632528F51EC400C9D3A0 /* dydxMarketDepthChartViewPresenter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0208632428F51EC400C9D3A0 /* dydxMarketDepthChartViewPresenter.swift */; };
-		020DBF1E29E092C00068AAA6 /* dydxTransferDepositViewPresenter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 020DBF1D29E092C00068AAA6 /* dydxTransferDepositViewPresenter.swift */; };
 		020EB697299D36AD00E8026B /* dydxApiStatusWorker.swift in Sources */ = {isa = PBXBuildFile; fileRef = 020EB696299D36AD00E8026B /* dydxApiStatusWorker.swift */; };
 		0214234C2DA74A5B000E9D54 /* dydxReactViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0214234B2DA74A5B000E9D54 /* dydxReactViewController.swift */; };
 		0216441128F36FBE00C7093E /* CandleDataPoint.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0216441028F36FBE00C7093E /* CandleDataPoint.swift */; };
@@ -496,7 +495,6 @@
 		0208627B28F4DAC000C9D3A0 /* dydxMarketInfoPagingViewPresenter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = dydxMarketInfoPagingViewPresenter.swift; sourceTree = "<group>"; };
 		0208630F28F5186E00C9D3A0 /* OrderbookLineDataPoint.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = OrderbookLineDataPoint.swift; sourceTree = "<group>"; };
 		0208632428F51EC400C9D3A0 /* dydxMarketDepthChartViewPresenter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = dydxMarketDepthChartViewPresenter.swift; sourceTree = "<group>"; };
-		020DBF1D29E092C00068AAA6 /* dydxTransferDepositViewPresenter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = dydxTransferDepositViewPresenter.swift; sourceTree = "<group>"; };
 		020EB696299D36AD00E8026B /* dydxApiStatusWorker.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = dydxApiStatusWorker.swift; sourceTree = "<group>"; };
 		0214234B2DA74A5B000E9D54 /* dydxReactViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = dydxReactViewController.swift; sourceTree = "<group>"; };
 		0216441028F36FBE00C7093E /* CandleDataPoint.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CandleDataPoint.swift; sourceTree = "<group>"; };
@@ -1268,7 +1266,6 @@
 			isa = PBXGroup;
 			children = (
 				023DB0962D69123500F15534 /* dydxInstantDepositViewPresenter.swift */,
-				020DBF1D29E092C00068AAA6 /* dydxTransferDepositViewPresenter.swift */,
 			);
 			path = Deposit;
 			sourceTree = "<group>";
@@ -2540,7 +2537,6 @@
 				02F700FE29EA0FD9004DEB5E /* dydxReceiptPresenter.swift in Sources */,
 				27457F5B2C8AC8B700873640 /* dydxVaultDepositWithdrawConfirmationViewBuilder.swift in Sources */,
 				027E1EF829CA27CD0098666F /* dydxSettingsLandingViewBuilder.swift in Sources */,
-				020DBF1E29E092C00068AAA6 /* dydxTransferDepositViewPresenter.swift in Sources */,
 				02B8341E2D50343400B955F5 /* OnboardingState.swift in Sources */,
 				277987512BA33F15006DC5CD /* dydxSelectedMarketStore.swift in Sources */,
 				0238FB72296C4438002E1C1A /* HistoricalPNLDataPoint.swift in Sources */,

dydx/dydxPresenters/dydxPresenters/_Features/features.json

@@ -93,26 +93,6 @@
                     ]
                 }
             },
-            {
-                "title":{
-                    "text":"Instant Deposit"
-                },
-                "field":{
-                    "field":"skip_go_fast",
-                    "optional":true,
-                    "type" : "bool",
-                    "options" : [
-                        {
-                            "text": "yes",
-                            "value" : 1
-                        },
-                        {
-                            "text": "no",
-                            "value" : 0
-                        }
-                    ]
-                }
-            },
             {
                 "title":{
                     "text":"Turnkey"

dydx/dydxPresenters/dydxPresenters/_v4/Receipt/dydxTransferReceiptViewPresenter.swift

@@ -27,7 +27,7 @@ final class dydxTransferReceiptViewPresenter: dydxReceiptPresenter {
         )
         .sink { [weak self] lines, input in
             var filteredLines = lines
-            if dydxBoolFeatureFlag.skip_go_fast.isEnabled && input.type == .deposit {
+            if input.type == .deposit {
                 filteredLines.removeAll {
                     $0 == .bridgefee || $0 == .transferrouteestimatedduration || $0 == .slippage
                 }

dydx/dydxPresenters/dydxPresenters/_v4/Transfer/Deposit/dydxTransferDepositViewPresenter.swift

@@ -11,15 +11,7 @@ import BigInt
 
 extension TransferInput {
     var tokenAddress: String? {
-        let tokenAddress: String?
-        if dydxBoolFeatureFlag.skip_go_fast.isEnabled {
-            tokenAddress = token
-        } else if let token = token {
-            tokenAddress = resources?.tokenResources?[token]?.address
-        } else {
-            tokenAddress = nil
-        }
-        return tokenAddress
+        token
     }
 
     var tokenDecimals: Int? {