Add sign in button to other portfolio tabs

Author: Sam-dYdX

ios/dydx/dydxPresenters/dydxPresenters/_v4/Portfolio/Components/dydxPortfolioFillsViewPresenter.swift

@@ -29,18 +29,19 @@ class dydxPortfolioFillsViewPresenter: HostedViewPresenter<dydxPortfolioFillsVie
         super.init()
 
         self.viewModel = viewModel
+        
+        viewModel?.onboardAction = {
+            Router.shared?.navigate(to: RoutingRequest(path: "/onboard"), animated: true, completion: { /* [weak self] */ _, _ in
+            })
+        }
     }
 
     override func start() {
         super.start()
 
         AbacusStateManager.shared.state.onboarded
             .sink { [weak self] onboarded in
-                if onboarded {
-                    self?.viewModel?.placeholderText = DataLocalizer.localize(path: "APP.GENERAL.PLACEHOLDER_NO_TRADES")
-                } else {
-                    self?.viewModel?.placeholderText = DataLocalizer.localize(path: "APP.GENERAL.PLACEHOLDER_NO_TRADES_LOG_IN")
-                }
+                self?.viewModel?.isSignedIn = onboarded
             }
             .store(in: &subscriptions)
 

ios/dydx/dydxPresenters/dydxPresenters/_v4/Portfolio/Components/dydxPortfolioFundingViewPresenter.swift

@@ -29,18 +29,19 @@ class dydxPortfolioFundingViewPresenter: HostedViewPresenter<dydxPortfolioFundin
         super.init()
 
         self.viewModel = viewModel
+        
+        viewModel?.onboardAction = {
+            Router.shared?.navigate(to: RoutingRequest(path: "/onboard"), animated: true, completion: { /* [weak self] */ _, _ in
+            })
+        }
     }
 
     override func start() {
         super.start()
 
         AbacusStateManager.shared.state.onboarded
             .sink { [weak self] onboarded in
-                if onboarded {
-                    self?.viewModel?.placeholderText = DataLocalizer.localize(path: "APP.GENERAL.PLACEHOLDER_NO_FUNDING")
-                } else {
-                    self?.viewModel?.placeholderText = DataLocalizer.localize(path: "APP.GENERAL.PLACEHOLDER_NO_FUNDING_LOG_IN")
-                }
+                self?.viewModel?.isSignedIn = onboarded
             }
             .store(in: &subscriptions)
 

ios/dydx/dydxPresenters/dydxPresenters/_v4/Portfolio/Components/dydxPortfolioOrdersViewPresenter.swift

@@ -29,18 +29,19 @@ class dydxPortfolioOrdersViewPresenter: HostedViewPresenter<dydxPortfolioOrdersV
         super.init()
 
         self.viewModel = viewModel
+        
+        viewModel?.onboardAction = {
+            Router.shared?.navigate(to: RoutingRequest(path: "/onboard"), animated: true, completion: { /* [weak self] */ _, _ in
+            })
+        }
     }
 
     override func start() {
         super.start()
 
         AbacusStateManager.shared.state.onboarded
             .sink { [weak self] onboarded in
-                if onboarded {
-                    self?.viewModel?.placeholderText = DataLocalizer.localize(path: "APP.GENERAL.PLACEHOLDER_NO_ORDERS")
-                } else {
-                    self?.viewModel?.placeholderText = DataLocalizer.localize(path: "APP.GENERAL.PLACEHOLDER_NO_ORDERS_LOG_IN")
-                }
+                self?.viewModel?.isSignedIn = onboarded
             }
             .store(in: &subscriptions)
 

ios/dydx/dydxViews/dydxViews/_v4/Portfolio/Components/Sections/dydxPortfolioFillsView.swift

@@ -11,12 +11,19 @@ import PlatformUI
 import Utilities
 
 public class dydxPortfolioFillsViewModel: PlatformListViewModel {
-    @Published public var placeholderText: String?
+    @Published public var isSignedIn: Bool = false
+    @Published public var onboardAction: (() -> Void)?
 
     public override var placeholder: PlatformViewModel? {
-        let vm = PlaceholderViewModel()
-        vm.text = placeholderText
-        return vm
+        guard self.isSignedIn else {
+            return PlatformButtonViewModel(
+                content: Text(DataLocalizer.localize(path: "APP.GENERAL.SIGN_IN_TO_VIEW")).wrappedViewModel,
+                action: { self.onboardAction?() }
+            )
+        }
+        return PlaceholderViewModel(
+            text: DataLocalizer.localize(path: "APP.TRADE.TRADES_EMPTY_STATE")
+        )
     }
 
     public init(items: [PlatformViewModel] = [], contentChanged: (() -> Void)? = nil) {

ios/dydx/dydxViews/dydxViews/_v4/Portfolio/Components/Sections/dydxPortfolioFundingView.swift

@@ -147,12 +147,19 @@ public class dydxPortfolioFundingItemViewModel: PlatformViewModel {
 }
 
 public class dydxPortfolioFundingViewModel: PlatformListViewModel {
-    @Published public var placeholderText: String?
+    @Published public var isSignedIn: Bool = false
+    @Published public var onboardAction: (() -> Void)?
 
     public override var placeholder: PlatformViewModel? {
-        let vm = PlaceholderViewModel()
-        vm.text = placeholderText
-        return vm
+        guard self.isSignedIn else {
+            return PlatformButtonViewModel(
+                content: Text(DataLocalizer.localize(path: "APP.GENERAL.SIGN_IN_TO_VIEW")).wrappedViewModel,
+                action: { self.onboardAction?() }
+            )
+        }
+        return PlaceholderViewModel(
+            text: DataLocalizer.localize(path: "APP.TRADE.FUNDING_EMPTY_STATE")
+        )
     }
 
     public init(items: [PlatformViewModel] = [], contentChanged: (() -> Void)? = nil) {

ios/dydx/dydxViews/dydxViews/_v4/Portfolio/Components/Sections/dydxPortfolioOrdersView.swift

@@ -183,12 +183,19 @@ public class dydxPortfolioOrderItemViewModel: PlatformViewModel {
 }
 
 public class dydxPortfolioOrdersViewModel: PlatformListViewModel {
-    @Published public var placeholderText: String?
+    @Published public var isSignedIn: Bool = false
+    @Published public var onboardAction: (() -> Void)?
 
     public override var placeholder: PlatformViewModel? {
-        let vm = PlaceholderViewModel()
-        vm.text = placeholderText
-        return vm
+        guard self.isSignedIn else {
+            return PlatformButtonViewModel(
+                content: Text(DataLocalizer.localize(path: "APP.GENERAL.SIGN_IN_TO_VIEW")).wrappedViewModel,
+                action: { self.onboardAction?() }
+            )
+        }
+        return PlaceholderViewModel(
+            text: DataLocalizer.localize(path: "APP.TRADE.ORDER_EMPTY_STATE")
+        )
     }
 
     public init(items: [PlatformViewModel] = [], contentChanged: (() -> Void)? = nil) {

ios/dydx/dydxViews/dydxViews/_v4/Portfolio/Components/Sections/dydxPortfolioPositionsView.swift

@@ -310,7 +310,7 @@ public class dydxPortfolioPositionsViewModel: PlatformViewModel {
         LazyVStack {
             if positionItems.isEmpty {
                 AnyView(
-                    PlaceholderViewModel(text: DataLocalizer.localize(path: "APP.GENERAL.PLACEHOLDER_NO_POSITIONS"))
+                    PlaceholderViewModel(text: DataLocalizer.localize(path: "APP.TRADE.POSITIONS_EMPTY_STATE"))
                         .createView()
                 )
             } else {