Moves data formatting to presenter

Author: Sam-dYdX

ios/dydx/dydxPresenters/dydxPresenters/_v4/Portfolio/Components/dydxPortfolioFillsViewPresenter.swift

@@ -80,7 +80,7 @@ class dydxPortfolioFillsViewPresenter: HostedViewPresenter<dydxPortfolioFillsVie
         item.type = DataLocalizer.localize(path: fill.resources.typeStringKey ?? "-")
         item.size = dydxFormatter.shared.localFormatted(number: fill.size, digits: configs.displayStepSizeDecimals?.intValue ?? 1)
         item.token?.symbol = asset.displayableAssetId
-        item.date = Date(milliseconds: fill.createdAtMilliseconds)
+        item.date = Date(milliseconds: fill.createdAtMilliseconds).englishDatetimeString
         if let tickSize = configs.displayTickSizeDecimals?.intValue {
             item.price = dydxFormatter.shared.dollar(number: fill.price, digits: tickSize)
             item.fee = dydxFormatter.shared.dollar(number: fill.fee, digits: tickSize)

ios/dydx/dydxPresenters/dydxPresenters/_v4/Portfolio/Components/dydxPortfolioFundingViewPresenter.swift

@@ -68,7 +68,7 @@ class dydxPortfolioFundingViewPresenter: HostedViewPresenter<dydxPortfolioFundin
             let item = cache[funding] ?? dydxPortfolioFundingItemViewModel()
             cache[funding] = item
 
-            item.time = Date(milliseconds: funding.createdAtMilliseconds)
+            item.time = Date(milliseconds: funding.createdAtMilliseconds).englishDatetimeString
             let amount = dydxFormatter.shared.dollar(number: abs(funding.payment), size: "0.0001")
             if funding.payment >= 0.0 {
                 item.amount = SignedAmountViewModel(text: amount, sign: .plus, coloringOption: .signOnly)

ios/dydx/dydxPresenters/dydxPresenters/_v4/Trade/TradeStatus/dydxTradeStatusViewBuilder.swift

@@ -171,7 +171,7 @@ private class dydxTradeStatusViewPresenter: HostedViewPresenter<dydxTradeStatusV
         viewModel?.orderViewModel.size = dydxFormatter.shared.localFormatted(number: lastOrder.size, digits: configs.stepSizeDecimals?.intValue ?? 1)
         viewModel?.orderViewModel.token?.symbol = asset.displayableAssetId
         if let createdAt = lastOrder.createdAtMilliseconds?.uint64Value {
-            viewModel?.orderViewModel.date = Date(milliseconds: createdAt)
+            viewModel?.orderViewModel.date = Date(milliseconds: createdAt).englishDatetimeString
         }
         if let tickSize = configs.tickSizeDecimals?.intValue {
             viewModel?.orderViewModel.price = dydxFormatter.shared.dollar(number: lastOrder.price, digits: tickSize)
@@ -205,7 +205,7 @@ private class dydxTradeStatusViewPresenter: HostedViewPresenter<dydxTradeStatusV
             viewModel?.orderViewModel.token?.symbol = token
         }
 
-        viewModel?.orderViewModel.date = submissionDate
+        viewModel?.orderViewModel.date = submissionDate?.englishDatetimeString
         if let tickSize = configs?.tickSizeDecimals?.intValue {
             if let price = tradeInput.summary?.price {
                 viewModel?.orderViewModel.price = dydxFormatter.shared.dollar(number: price, digits: tickSize)
@@ -239,7 +239,7 @@ private class dydxTradeStatusViewPresenter: HostedViewPresenter<dydxTradeStatusV
         if let token = asset?.displayableAssetId ?? configsAndAsset?.assetId {
             viewModel?.orderViewModel.token?.symbol = token
         }
-        viewModel?.orderViewModel.date = submissionDate
+        viewModel?.orderViewModel.date = submissionDate?.englishDatetimeString
         if let tickSize = configs?.tickSizeDecimals?.intValue {
             viewModel?.orderViewModel.price = dydxFormatter.shared.dollar(number: closePositionInput.summary?.price, digits: tickSize)
             viewModel?.orderViewModel.fee = dydxFormatter.shared.dollar(number: closePositionInput.summary?.fee, digits: tickSize)

ios/dydx/dydxViews/dydxViews/_v4/Portfolio/Components/Sections/dydxPortfolioFundingView.swift

@@ -44,7 +44,7 @@ public enum FundingStatus {
 
 public class dydxPortfolioFundingItemViewModel: PlatformViewModel {
 
-    public init(amount: SignedAmountViewModel? = nil, rate: SignedAmountViewModel? = nil, time: Date? = nil, sideText: SideTextViewModel = SideTextViewModel(), status: FundingStatus = .paid, position: String? = nil, token: TokenTextViewModel? = TokenTextViewModel(), logoUrl: URL? = nil, onTapAction: (() -> Void)? = nil) {
+    public init(amount: SignedAmountViewModel? = nil, rate: SignedAmountViewModel? = nil, time: String? = nil, sideText: SideTextViewModel = SideTextViewModel(), status: FundingStatus = .paid, position: String? = nil, token: TokenTextViewModel? = TokenTextViewModel(), logoUrl: URL? = nil, onTapAction: (() -> Void)? = nil) {
         self.amount = amount
         self.rate = rate
         self.time = time
@@ -58,7 +58,7 @@ public class dydxPortfolioFundingItemViewModel: PlatformViewModel {
 
     public var amount: SignedAmountViewModel?
     public var rate: SignedAmountViewModel?
-    public var time: Date?
+    public var time: String?
     public var sideText = SideTextViewModel()
     public var status: FundingStatus = .paid
     public var position: String?
@@ -69,7 +69,7 @@ public class dydxPortfolioFundingItemViewModel: PlatformViewModel {
     public static var previewValue: dydxPortfolioFundingItemViewModel {
         let item = dydxPortfolioFundingItemViewModel(amount: .previewValue,
                                                      rate: .previewValue,
-                                                     time: Date(),
+                                                     time: Date().englishDatetimeString,
                                                      sideText: .previewValue,
                                                      status: .paid,
                                                      position: "$2300.0",
@@ -120,7 +120,7 @@ public class dydxPortfolioFundingItemViewModel: PlatformViewModel {
                     .themeFont(fontSize: .medium)
                 sideText.createView(parentStyle: parentStyle.themeFont(fontSize: .medium))
             }
-            Text(time?.englishDatetimeString ?? "")
+            Text(time ?? "")
                 .themeColor(foreground: .textTertiary)
                 .themeFont(fontSize: .smallest)
         }

ios/dydx/dydxViews/dydxViews/_v4/Portfolio/Shared/SharedFillView.swift

@@ -21,7 +21,7 @@ public class SharedFillViewModel: PlatformViewModel {
         public var onTapAction: (() -> Void)?
     }
 
-    public init(type: String? = nil, amount: String? = nil, date: Date? = nil, price: String? = nil, fee: String? = nil, feeLiquidity: String? = nil, sideText: SideTextViewModel = SideTextViewModel(), token: TokenTextViewModel? = TokenTextViewModel(), logoUrl: URL? = nil, onTapAction: (() -> Void)? = nil) {
+    public init(type: String? = nil, amount: String? = nil, date: String? = nil, price: String? = nil, fee: String? = nil, feeLiquidity: String? = nil, sideText: SideTextViewModel = SideTextViewModel(), token: TokenTextViewModel? = TokenTextViewModel(), logoUrl: URL? = nil, onTapAction: (() -> Void)? = nil) {
         self.type = type
         self.size = amount
         self.date = date
@@ -36,7 +36,7 @@ public class SharedFillViewModel: PlatformViewModel {
 
     @Published public var type: String?
     @Published public var size: String?
-    @Published public var date: Date?
+    @Published public var date: String?
     @Published public var price: String?
     @Published public var fee: String?
     @Published public var feeLiquidity: String?
@@ -50,7 +50,7 @@ public class SharedFillViewModel: PlatformViewModel {
     public static var previewValue: SharedFillViewModel {
         let vm = SharedFillViewModel(type: "Market Order",
                                      amount: "0.017 ETH",
-                                     date: Date(),
+                                     date: Date().englishDatetimeString,
                                      price: "$1,203.8",
                                      fee: "$0.0",
                                      feeLiquidity: "Taker",
@@ -108,7 +108,7 @@ public class SharedFillViewModel: PlatformViewModel {
                     .themeColor(foreground: .textPrimary)
                     .themeFont(fontSize: .medium)
             }
-            Text(date?.englishDatetimeString ?? "")
+            Text(date ?? "")
                 .themeColor(foreground: .textTertiary)
                 .themeFont(fontSize: .smallest)
         }