Adds sign in button in positions when user is not signed in

Author: Sam-dYdX

ios/dydx/dydxPresenters/dydxPresenters/_v4/Portfolio/Components/dydxPortfolioPositionsViewPresenter.swift

@@ -29,18 +29,18 @@ class dydxPortfolioPositionsViewPresenter: HostedViewPresenter<dydxPortfolioPosi
         viewModel?.vaultTapAction = {
             Router.shared?.navigate(to: RoutingRequest(path: "/vault"), animated: true, completion: nil)
         }
+        viewModel?.onboardAction = {
+            Router.shared?.navigate(to: RoutingRequest(path: "/onboard"), animated: true, completion: { /* [weak self] */ _, _ in
+            })
+        }
     }
 
     override func start() {
         super.start()
 
         AbacusStateManager.shared.state.onboarded
             .sink { [weak self] onboarded in
-                if onboarded {
-                    self?.viewModel?.emptyText = DataLocalizer.localize(path: "APP.GENERAL.PLACEHOLDER_NO_POSITIONS")
-                } else {
-                    self?.viewModel?.emptyText = DataLocalizer.localize(path: "APP.GENERAL.PLACEHOLDER_NO_POSITIONS_LOG_IN")
-                }
+                self?.viewModel?.isSignedIn = onboarded
             }
             .store(in: &subscriptions)
 

ios/dydx/dydxViews/dydxViews/_v4/Portfolio/Components/Sections/dydxPortfolioPositionsView.swift

@@ -244,7 +244,6 @@ public class dydxPortfolioPositionItemViewModel: PlatformViewModel {
 }
 
 public class dydxPortfolioPositionsViewModel: PlatformViewModel {
-    @Published public var emptyText: String?
     @Published public var positionItems: [dydxPortfolioPositionItemViewModel] {
         didSet {
             contentChanged?()
@@ -259,19 +258,19 @@ public class dydxPortfolioPositionsViewModel: PlatformViewModel {
     @Published public var vaultBalance: String?
     @Published public var vaultApy: Double?
     @Published public var vaultTapAction: (() -> Void)?
+    @Published public var isSignedIn: Bool = false
+    @Published public var onboardAction: (() -> Void)?
 
     public var contentChanged: (() -> Void)?
 
     init(
         positionItems: [dydxPortfolioPositionItemViewModel] = [],
         pendingPositionItems: [dydxPortfolioPendingPositionsItemViewModel] = [],
         vaultBalance: String? = nil,
-        vaultApy: String? = nil,
-        emptyText: String? = nil
+        vaultApy: String? = nil
     ) {
         self.positionItems = positionItems
         self.pendingPositionItems = pendingPositionItems
-        self.emptyText = emptyText
     }
 
     public static var previewValue: dydxPortfolioPositionsViewModel {
@@ -283,8 +282,8 @@ public class dydxPortfolioPositionsViewModel: PlatformViewModel {
             pendingPositionItems: [
                 .previewValue
             ],
-            vaultBalance: "324.320",
-            emptyText: "empty")
+            vaultBalance: "324.320"
+        )
     }
 
     public var pendingPositionsHeader: PlatformViewModel? {
@@ -309,9 +308,9 @@ public class dydxPortfolioPositionsViewModel: PlatformViewModel {
 
     private var openPositionsView: some View {
         LazyVStack {
-            if let emptyText = self.emptyText, positionItems.isEmpty {
+            if positionItems.isEmpty {
                 AnyView(
-                    PlaceholderViewModel(text: emptyText)
+                    PlaceholderViewModel(text: DataLocalizer.localize(path: "APP.GENERAL.PLACEHOLDER_NO_POSITIONS"))
                         .createView()
                 )
             } else {
@@ -398,6 +397,14 @@ public class dydxPortfolioPositionsViewModel: PlatformViewModel {
     public override func createView(parentStyle: ThemeStyle = ThemeStyle.defaultStyle, styleKey: String? = nil) -> PlatformView {
         PlatformView(viewModel: self, parentStyle: parentStyle, styleKey: styleKey) { [weak self] _ in
             guard let self = self else { return AnyView(PlatformView.nilView) }
+            guard self.isSignedIn else {
+                return PlatformButtonViewModel(
+                    content: Text(DataLocalizer.localize(path: "APP.GENERAL.SIGN_IN_TO_VIEW")).wrappedViewModel,
+                    action: { self.onboardAction?() }
+                )
+                .createView(parentStyle: parentStyle)
+                .wrappedInAnyView()
+            }
 
             return AnyView(
                 ScrollView {