fix: quiet expected errors (#1917)

Author: jaredvu

src/lib/turnkey/turnkeyUtils.ts

@@ -33,9 +33,18 @@ export async function getWalletsWithAccountsFromClient(
   return walletWithAccounts;
 }
 
-export const parseTurnkeyError = (message: string, stringGetter: StringGetterFunction): string => {
+export const parseTurnkeyError = (
+  message: string,
+  stringGetter: StringGetterFunction
+): {
+  errorMessage: string;
+  shouldLog: boolean;
+} => {
   if (message.includes('User has already registered using this email')) {
-    return stringGetter({ key: STRING_KEYS.USER_ALREADY_HAS_TURNKEY });
+    return {
+      errorMessage: stringGetter({ key: STRING_KEYS.USER_ALREADY_HAS_TURNKEY }),
+      shouldLog: false,
+    };
   }
 
   if (
@@ -44,11 +53,17 @@ export const parseTurnkeyError = (message: string, stringGetter: StringGetterFun
     message.includes('Unauthenticated desc') ||
     message.includes('Organization ID was not found')
   ) {
-    return stringGetter({ key: STRING_KEYS.INVALID_TURNKEY_EMAIL_LINK });
+    return {
+      errorMessage: stringGetter({ key: STRING_KEYS.INVALID_TURNKEY_EMAIL_LINK }),
+      shouldLog: false,
+    };
   }
 
-  return stringGetter({
-    key: STRING_KEYS.SOMETHING_WENT_WRONG_WITH_MESSAGE,
-    params: { ERROR_MESSAGE: message },
-  });
+  return {
+    errorMessage: stringGetter({
+      key: STRING_KEYS.SOMETHING_WENT_WRONG_WITH_MESSAGE,
+      params: { ERROR_MESSAGE: message },
+    }),
+    shouldLog: true,
+  };
 };

src/providers/TurnkeyAuthProvider.tsx

@@ -85,6 +85,7 @@ const useTurnkeyAuthContext = () => {
 
   const {
     embeddedPublicKey,
+    endTurnkeySession,
     setIsNewTurnkeyUser,
     onboardDydx,
     targetPublicKeys,
@@ -164,9 +165,14 @@ const useTurnkeyAuthContext = () => {
     },
     onError: (error, variables) => {
       selectWallet(undefined);
-      logBonsaiError('TurnkeyOnboarding', 'Error during sign-in', { error });
       setEmailSignInStatus('error');
-      setEmailSignInError(parseTurnkeyError(error.message, stringGetter));
+      const { errorMessage, shouldLog } = parseTurnkeyError(error.message, stringGetter);
+      setEmailSignInError(errorMessage);
+      endTurnkeySession();
+
+      if (shouldLog) {
+        logBonsaiError('TurnkeyOnboarding', 'Error during sign-in', { error });
+      }
 
       if (variables.loginMethod === LoginMethod.OAuth) {
         const providerName = variables.providerName;
@@ -336,8 +342,16 @@ const useTurnkeyAuthContext = () => {
         let errorMessage: string | undefined;
 
         if (error instanceof Error) {
-          errorMessage = parseTurnkeyError(error.message, stringGetter);
-          logBonsaiError('TurnkeyOnboarding', 'error handling email magic link', { error });
+          const { errorMessage: message, shouldLog } = parseTurnkeyError(
+            error.message,
+            stringGetter
+          );
+
+          if (shouldLog) {
+            logBonsaiError('TurnkeyOnboarding', 'error handling email magic link', { error });
+          }
+
+          errorMessage = message;
         } else {
           logBonsaiError('TurnkeyOnboarding', 'error handling email magic link - unknown', {
             error,
@@ -351,6 +365,8 @@ const useTurnkeyAuthContext = () => {
               params: { ERROR_MESSAGE: stringGetter({ key: STRING_KEYS.UNKNOWN_ERROR }) },
             })
         );
+
+        endTurnkeySession();
         setEmailSignInStatus('error');
       } finally {
         // Clear token from state after it has been consumed
@@ -373,6 +389,7 @@ const useTurnkeyAuthContext = () => {
       setSearchParams,
       dispatch,
       stringGetter,
+      endTurnkeySession,
     ]
   );
 

src/views/dialogs/ManageAccountDialog/RevealPhrase.tsx

@@ -235,7 +235,7 @@ export const RevealPhrase = ({
   );
 
   const iframeCss = `
-    iframe {
+    #${TurnkeyExportIframeContainerId} > iframe {
         padding: 0.75rem;
         width: 100%;
         height: 100%;