fix: remove c-factor rewards display (#1930)

Author: tyleroooo

src/bonsai/ontology.ts

@@ -6,7 +6,6 @@ import { AccountAuthenticator } from '@/constants/validators';
 import {
   IndexerFundingPaymentResponseObject,
   IndexerHistoricalBlockTradingReward,
-  IndexerHistoricalTradingRewardAggregation,
 } from '@/types/indexer/indexerApiGen';
 import { IndexerWsTradesUpdateObject } from '@/types/indexer/indexerManual';
 
@@ -24,12 +23,6 @@ import { Loadable, LoadableStatus } from './lib/loadable';
 import { useCurrentMarketHistoricalFunding } from './rest/funding';
 import { useFundingPayments } from './rest/fundingPayments';
 import { SubaccountPnlTick, useParentSubaccountHistoricalPnls } from './rest/historicalPnl';
-import {
-  useDailyCumulativeTradingRewards,
-  useHistoricalTradingRewards,
-  useHistoricalTradingRewardsWeekly,
-  useTotalTradingRewards,
-} from './rest/historicalTradingRewards';
 import { useAuthorizedAccounts } from './rest/permissionedKeys';
 import {
   StakingDelegationsResult,
@@ -112,7 +105,6 @@ import { DepthChartData, OrderbookProcessedData } from './types/orderbookTypes';
 import { MarketsData, ParentSubaccountDataBase } from './types/rawTypes';
 import {
   AccountBalances,
-  AggregatedTradingReward,
   AllAssetData,
   ApiState,
   AssetData,
@@ -421,11 +413,7 @@ interface BonsaiHooksShape {
   useAuthorizedAccounts: () => Loadable<AccountAuthenticator[]>;
   useCurrentMarketHistoricalFunding: () => Loadable<HistoricalFundingObject[]>;
   useCurrentMarketLiveTrades: () => Loadable<IndexerWsTradesUpdateObject>;
-  useDailyCumulativeTradingRewards: () => Loadable<AggregatedTradingReward[]>;
-  useHistoricalTradingRewards: () => Loadable<IndexerHistoricalTradingRewardAggregation[]>;
-  useHistoricalTradingRewardsWeekly: () => Loadable<BigNumber>;
   useParentSubaccountHistoricalPnls: () => Loadable<SubaccountPnlTick[]>;
-  useTotalTradingRewards: () => Loadable<BigNumber>;
   useStakingRewards: () => Loadable<StakingRewards>;
   useUnbondingDelegations: () => Loadable<UnbondingDelegation[]>;
   useStakingDelegations: () => Loadable<StakingDelegationsResult>;
@@ -436,13 +424,9 @@ export const BonsaiHooks: BonsaiHooksShape = {
   useAuthorizedAccounts,
   useCurrentMarketHistoricalFunding,
   useCurrentMarketLiveTrades: useCurrentMarketTradesValue,
-  useDailyCumulativeTradingRewards,
-  useHistoricalTradingRewards,
   useFundingPayments,
-  useHistoricalTradingRewardsWeekly,
   useParentSubaccountHistoricalPnls,
   useStakingRewards,
-  useTotalTradingRewards,
   useUnbondingDelegations,
   useStakingDelegations,
 };

src/pages/Profile.tsx

@@ -1,4 +1,3 @@
-import { BonsaiHooks } from '@/bonsai/ontology';
 import { Link as ReactLink, useNavigate } from 'react-router-dom';
 import styled, { css } from 'styled-components';
 import tw from 'twin.macro';
@@ -15,17 +14,14 @@ import { useAccounts } from '@/hooks/useAccounts';
 import { useComplianceState } from '@/hooks/useComplianceState';
 import { useEnvConfig } from '@/hooks/useEnvConfig';
 import { useStringGetter } from '@/hooks/useStringGetter';
-import { useTokenConfigs } from '@/hooks/useTokenConfigs';
 
 import breakpoints from '@/styles/breakpoints';
 import { layoutMixins } from '@/styles/layoutMixins';
 
-import { AssetIcon } from '@/components/AssetIcon';
 import { Details } from '@/components/Details';
 import { Icon, IconName } from '@/components/Icon';
 import { IconButton, type IconButtonProps } from '@/components/IconButton';
 import { Link } from '@/components/Link';
-import { Output, OutputType } from '@/components/Output';
 import { Panel } from '@/components/Panel';
 import { Toolbar } from '@/components/Toolbar';
 import { FillsTable, FillsTableColumnKey } from '@/views/tables/FillsTable';
@@ -63,9 +59,7 @@ const Profile = () => {
   const isConnected = onboardingState !== OnboardingState.Disconnected;
 
   const { sourceAccount, dydxAddress } = useAccounts();
-  const { chainTokenImage, chainTokenLabel } = useTokenConfigs();
   const { disableConnectButton } = useComplianceState();
-  const currentWeekTradingReward = BonsaiHooks.useHistoricalTradingRewardsWeekly().data;
 
   const { data: ensName } = useEnsName({
     address:
@@ -187,30 +181,6 @@ const Profile = () => {
 
       <StakingPanel tw="[grid-area:staking]" />
 
-      <$RewardsPanel
-        slotHeaderContent={stringGetter({ key: STRING_KEYS.TRADING_REWARDS })}
-        href={`/${chainTokenLabel}`}
-        hasSeparator
-      >
-        <$Details
-          items={[
-            {
-              key: 'week-rewards',
-              label: stringGetter({ key: STRING_KEYS.THIS_WEEK }),
-              value: (
-                <Output
-                  slotRight={
-                    <AssetIcon logoUrl={chainTokenImage} symbol={chainTokenLabel} tw="ml-[0.5ch]" />
-                  }
-                  type={OutputType.Asset}
-                  value={currentWeekTradingReward}
-                />
-              ),
-            },
-          ]}
-          layout="grid"
-        />
-      </$RewardsPanel>
       <Panel
         slotHeaderContent={stringGetter({ key: STRING_KEYS.FEES })}
         href={`${AppRoute.Portfolio}/${PortfolioRoute.Fees}`}
@@ -278,7 +248,7 @@ const $MobileProfileLayout = styled.div`
     'actions actions'
     'settings help'
     'staking staking'
-    'rewards fees'
+    'fees fees'
     'history history'
     'governance governance'
     'incentives incentives'
@@ -290,7 +260,7 @@ const $MobileProfileLayout = styled.div`
       'actions actions'
       'settings help'
       'staking staking'
-      'rewards fees'
+      'fees fees'
       'history history'
       'governance governance'
       'incentives incentives'
@@ -373,18 +343,6 @@ const $ActionButton = styled(IconButton)<{ iconName?: IconName }>`
 
 const $Details = tw(Details)`font-small-book [--details-value-font:--font-medium-book]`;
 
-const $RewardsPanel = styled(Panel)`
-  grid-area: rewards;
-  align-self: flex-start;
-  height: 100%;
-  > div {
-    height: 100%;
-  }
-
-  dl {
-    --details-grid-numColumns: 1;
-  }
-`;
 const $HistoryPanel = styled(Panel)`
   grid-area: history;
   --panel-content-paddingY: 0;

src/pages/token/RewardHistoryPanel.tsx

@@ -25,7 +25,6 @@ import { orEmptyObj } from '@/lib/typeUtils';
 
 import { GeoblockedPanel } from './GeoblockedPanel';
 import { LaunchIncentivesPanel } from './LaunchIncentivesPanel';
-import { RewardHistoryPanel } from './RewardHistoryPanel';
 import { RewardsHelpPanel } from './RewardsHelpPanel';
 import { RewardsLeaderboardPanel } from './RewardsLeaderboardPanel';
 import { StakingPanel } from './StakingPanel';
@@ -77,7 +76,6 @@ const RewardsPage = () => {
             <StakingPanel />
             <UnbondingPanels />
             <LaunchIncentivesPanel />
-            <RewardHistoryPanel />
             <RewardsHelpPanel />
             {legalDisclaimer}
           </$DetachedSection>
@@ -88,7 +86,6 @@ const RewardsPage = () => {
             <div tw="flexColumn flex-[2] gap-1.5">
               <LaunchIncentivesPanel />
               <RewardsLeaderboardPanel />
-              <RewardHistoryPanel />
             </div>
             <div tw="flexColumn flex-1 gap-1.5">
               {showGeoblockedPanel && <GeoblockedPanel />}