fix: don't poll for order inclusion on chain and also log time for market orders to fill (#1932)

Author: tyleroooo

package.json

@@ -54,7 +54,7 @@
     "@cosmjs/stargate": "^0.32.1",
     "@cosmjs/tendermint-rpc": "^0.32.1",
     "@datadog/browser-logs": "^5.23.3",
-    "@dydxprotocol/v4-client-js": "3.0.3",
+    "@dydxprotocol/v4-client-js": "3.0.5",
     "@dydxprotocol/v4-localization": "1.1.334",
     "@dydxprotocol/v4-proto": "^7.0.0-dev.0",
     "@emotion/is-prop-valid": "^1.3.0",

pnpm-lock.yaml

@@ -13,6 +13,7 @@ import { logBonsaiError, logBonsaiInfo } from '@/bonsai/logs';
 import { BonsaiCore } from '@/bonsai/ontology';
 import { OrderStatus, SubaccountOrder } from '@/bonsai/types/summaryTypes';
 import { IndexedTx } from '@cosmjs/stargate';
+import { Method } from '@cosmjs/tendermint-rpc';
 import {
   CompositeClient,
   LocalWallet,
@@ -31,6 +32,7 @@ import {
   TransactionMemo,
 } from '@/constants/analytics';
 import { STRING_KEYS } from '@/constants/localization';
+import { timeUnits } from '@/constants/time';
 import {
   MARKET_ORDER_MAX_SLIPPAGE,
   POST_TRANSFER_PLACE_ORDER_DELAY,
@@ -80,6 +82,12 @@ interface TransactionSupervisorShared {
   stateNotifier: StateConditionNotifier;
 }
 
+const selectOrdersAndFills = createAppSelector(
+  BonsaiCore.account.allOrders.data,
+  BonsaiCore.account.fills.data,
+  (orders, fills) => ({ orders, fills })
+);
+
 interface CancelOrderPayload {
   clientId: number;
   orderFlags: OrderFlags;
@@ -407,6 +415,9 @@ export class AccountTransactionSupervisor {
   }
 
   private async executePlaceOrder(payload: PlaceOrderPayload): Promise<OperationResult<any>> {
+    const totalTimer = startTimer();
+    const afterSubmitTimer = createTimer();
+
     const placeOrderResult = await this.wrapOperation(
       'AccountTransactionSupervisor/placeOrder',
       payload,
@@ -459,7 +470,8 @@ export class AccountTransactionSupervisor {
           marketInfo ?? undefined,
           currentHeight ?? undefined,
           goodTilBlock ?? undefined,
-          memo
+          memo,
+          Method.BroadcastTxSync
         );
 
         if ((tx as IndexedTx | undefined)?.code !== 0) {
@@ -489,6 +501,43 @@ export class AccountTransactionSupervisor {
       );
     }
 
+    // Log market order fills
+    if (isOperationSuccess(placeOrderResult) && payload.type === OrderType.MARKET) {
+      afterSubmitTimer.start();
+      this.shared.stateNotifier.notifyWhenTrue(
+        selectOrdersAndFills,
+        ({ orders, fills }) => {
+          const matchingOrder = orders.find((order) => order.clientId === `${payload.clientId}`);
+          if (matchingOrder?.id == null) {
+            return undefined;
+          }
+
+          const matchingFill = fills.find((fill) => fill.orderId === matchingOrder.id);
+          if (matchingFill != null) {
+            return { order: matchingOrder, fill: matchingFill };
+          }
+
+          return undefined;
+        },
+        (result) => {
+          if (result != null) {
+            logBonsaiInfo('AccountTransactionSupervisor/placeOrder', 'Market order filled', {
+              payload,
+              order: purgeBigNumbers(result.order),
+              fill: purgeBigNumbers(result.fill),
+              totalTimeToFill: totalTimer.elapsed(),
+              timeToFillAfterSubmit: afterSubmitTimer.elapsed(),
+            });
+          } else {
+            logBonsaiInfo('AccountTransactionSupervisor/placeOrder', 'Market order never filled', {
+              payload,
+            });
+          }
+        },
+        10 * timeUnits.second
+      );
+    }
+
     return placeOrderResult;
   }
 
@@ -1193,7 +1242,8 @@ export class AccountTransactionSupervisor {
                   cancelRawOrderPayloads,
                   transferToSubaccountPayload,
                   payload.placePayloads,
-                  TransactionMemo.placeOrder
+                  TransactionMemo.placeOrder,
+                  Method.BroadcastTxSync
                 );
 
                 if ((tx as IndexedTx | undefined)?.code !== 0) {