Skip to content

Commit f4d5daa

Browse files
authored
fix: only cancel referral code edits explicitly via the cancel button (#1923)
1 parent 433b130 commit f4d5daa

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

src/views/dialogs/ShareAffiliateDialog.tsx

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ export const ShareAffiliateDialog = ({ setIsOpen }: DialogProps<ShareAffiliateDi
7474
const [validationError, setValidationError] = useState<string | null>(null);
7575

7676
const affiliateInputRef = useRef<HTMLInputElement>(null);
77-
const confirmButtonRef = useRef<HTMLButtonElement>(null);
7877

7978
const maxEarning = maxEarningData?.maxEarning;
8079

@@ -150,19 +149,12 @@ export const ShareAffiliateDialog = ({ setIsOpen }: DialogProps<ShareAffiliateDi
150149
updateReferralCodeMutate(editableReferralCode);
151150
}, [editableReferralCode, updateReferralCodeMutate]);
152151

153-
const handleCancelEdit = useCallback(
154-
(e?: React.FocusEvent<HTMLInputElement>) => {
155-
if (e?.relatedTarget === confirmButtonRef.current) {
156-
return;
157-
}
158-
159-
setEditableReferralCode(data?.metadata?.referralCode ?? '');
160-
setIsEditMode(false);
161-
setUpdateError(null);
162-
setValidationError(null);
163-
},
164-
[data?.metadata?.referralCode]
165-
);
152+
const handleCancelEdit = useCallback(() => {
153+
setEditableReferralCode(data?.metadata?.referralCode ?? '');
154+
setIsEditMode(false);
155+
setUpdateError(null);
156+
setValidationError(null);
157+
}, [data?.metadata?.referralCode]);
166158

167159
const handleReferralInputChange = (e: React.ChangeEvent<HTMLInputElement>) => {
168160
const newUrl = e.target.value;
@@ -273,9 +265,9 @@ export const ShareAffiliateDialog = ({ setIsOpen }: DialogProps<ShareAffiliateDi
273265
action={ButtonAction.Destroy}
274266
shape={ButtonShape.Square}
275267
state={{ isDisabled: isUpdatingReferralCode }}
268+
onClick={handleCancelEdit}
276269
/>
277270
<IconButton
278-
ref={confirmButtonRef}
279271
iconName={IconName.Check}
280272
size={ButtonSize.Small}
281273
onClick={handleConfirmEdit}
@@ -294,6 +286,7 @@ export const ShareAffiliateDialog = ({ setIsOpen }: DialogProps<ShareAffiliateDi
294286
}, [
295287
affiliatesUrl,
296288
editableReferralCode.length,
289+
handleCancelEdit,
297290
handleConfirmEdit,
298291
isEditMode,
299292
isUpdatingReferralCode,
@@ -334,7 +327,6 @@ export const ShareAffiliateDialog = ({ setIsOpen }: DialogProps<ShareAffiliateDi
334327
disabled={!isEditMode}
335328
$backgroundColorOverride="transparent"
336329
$withEllipsis
337-
onBlur={handleCancelEdit}
338330
/>
339331
</div>
340332
<ActionButtonsElement />

0 commit comments

Comments
 (0)