feat: closed pnl #1966
Open
feat: closed pnl #1966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
qardpeet
reviewed
Nov 5, 2025
pp346
commented
Nov 5, 2025
jaredvu
reviewed
Nov 5, 2025
src/views/tables/FillsTable.tsx
Outdated
Comment on lines
267
to
270
| <Output | ||
| type={closedPnl === '--' ? OutputType.Text : OutputType.Fiat} | ||
| value={closedPnl} | ||
| /> |
Contributor
There was a problem hiding this comment.
Do we want to show positive/negative color for this cell?
Contributor
Author
There was a problem hiding this comment.
talked with shrenuj about it and we'll keep it neutral since that's what hyperliquid does
jaredvu
reviewed
Nov 5, 2025
jaredvu
reviewed
Nov 5, 2025
src/views/tables/FillsTable.tsx
Outdated
| } | ||
|
|
||
| const calculateClosedPnl = (fill: FillTableRow) => { | ||
| const fee = parseFloat(fill.fee ?? '0'); |
Contributor
There was a problem hiding this comment.
instead of parseFloat, you can use maybeBigNumber
Contributor
Author
There was a problem hiding this comment.
used MustNumber instead!
jaredvu
reviewed
Nov 5, 2025
jaredvu
reviewed
Nov 5, 2025
jaredvu
reviewed
Nov 5, 2025
jaredvu
approved these changes
Nov 5, 2025
UnbornAztecKing
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issue
-https://linear.app/dydx/issue/ENG-1194/finish-closed-pnl-history-frontend
Related Issues (Optional)
Screenshots/Recordings (Optional)