Potential fix for code scanning alert no. 366: Generic catch clause

dylan-mccarthy · github-advanced-security[bot] · web-flow · commit 8e5739d4b1d9 · 2025-11-01T07:47:36.000+11:00
Co-authored-by: Copilot Autofix powered by AI &lt;62310815+github-advanced-security[bot]@users.noreply.github.com&gt;
diff --git a/src/Node.Runtime/Services/LeasePullService.cs b/src/Node.Runtime/Services/LeasePullService.cs
@@ -539,7 +539,13 @@ private async Task ProcessLeaseAsync(Lease lease, CancellationToken cancellation
             {
                 _logger.LogError(rpcEx, "gRPC error reporting failure for lease {LeaseId}: {StatusCode}", lease.LeaseId, rpcEx.StatusCode);
             }
-            catch (Exception failEx)
+            // Only catch non-fatal exceptions during failure reporting.
+            // Do not catch OutOfMemoryException, StackOverflowException, or ThreadAbortException
+            catch (Exception failEx) when (
+                !(failEx is OutOfMemoryException) &&
+                !(failEx is StackOverflowException) &&
+                !(failEx is ThreadAbortException)
+            )
             {
                 _logger.LogError(failEx, "Unexpected error reporting failure for lease {LeaseId}", lease.LeaseId);
             }

Original file line number	Diff line number	Diff line change
`@@ -539,7 +539,13 @@ private async Task ProcessLeaseAsync(Lease lease, CancellationToken cancellation`
`539`	`539`	`{`
`540`	`540`	`_logger.LogError(rpcEx, "gRPC error reporting failure for lease {LeaseId}: {StatusCode}", lease.LeaseId, rpcEx.StatusCode);`
`541`	`541`	`}`
`542`		`- catch (Exception failEx)`
	`542`	`+ // Only catch non-fatal exceptions during failure reporting.`
	`543`	`+ // Do not catch OutOfMemoryException, StackOverflowException, or ThreadAbortException`
	`544`	`+ catch (Exception failEx) when (`
	`545`	`+ !(failEx is OutOfMemoryException) &&`
	`546`	`+ !(failEx is StackOverflowException) &&`
	`547`	`+ !(failEx is ThreadAbortException)`
	`548`	`+ )`
`543`	`549`	`{`
`544`	`550`	`_logger.LogError(failEx, "Unexpected error reporting failure for lease {LeaseId}", lease.LeaseId);`
`545`	`551`	`}`