Skip to content

Commit a79ed3e

Browse files
fix(security): fix 4 null safety issues in TelemetryConfigTests.cs
- Added null-forgiving operator (!) after Assert.NotNull checks - CodeQL cannot infer that Assert.NotNull guarantees non-null - Lines 125, 194, 214, 241 Refs: E7-T1
1 parent c120332 commit a79ed3e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tests/Node.Runtime.Tests/TelemetryConfigTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public void Activity_CanHaveTags()
122122

123123
// Assert
124124
Assert.NotNull(activity);
125-
var tags = activity.Tags.ToList();
125+
var tags = activity!.Tags.ToList();
126126
Assert.Contains(tags, tag => tag.Key == "agent.id" && tag.Value == "test-agent");
127127
Assert.Contains(tags, tag => tag.Key == "llm.model" && tag.Value == "gpt-4");
128128
Assert.Contains(tags, tag => tag.Key == "connector.type" && tag.Value == "ServiceBus");
@@ -191,7 +191,7 @@ public void Activity_CanSetStatus()
191191

192192
// Assert
193193
Assert.NotNull(activity);
194-
Assert.Equal(ActivityStatusCode.Ok, activity.Status);
194+
Assert.Equal(ActivityStatusCode.Ok, activity!.Status);
195195
}
196196

197197
[Fact]
@@ -211,7 +211,7 @@ public void Activity_CanSetErrorStatus()
211211

212212
// Assert
213213
Assert.NotNull(activity);
214-
Assert.Equal(ActivityStatusCode.Error, activity.Status);
214+
Assert.Equal(ActivityStatusCode.Error, activity!.Status);
215215
Assert.Equal("Test error message", activity.StatusDescription);
216216
}
217217

@@ -238,7 +238,7 @@ public void Activity_CanAddEvents()
238238

239239
// Assert
240240
Assert.NotNull(activity);
241-
Assert.Single(activity.Events);
241+
Assert.Single(activity!.Events);
242242
var activityEvent = activity.Events.First();
243243
Assert.Equal("exception", activityEvent.Name);
244244
Assert.Contains(activityEvent.Tags, tag => tag.Key == "exception.type" && tag.Value?.ToString() == "System.Exception");

0 commit comments

Comments
 (0)